Skip to content

Commit 35ba1d8

Browse files
committed
Blacken openstackclient.volume
Black used with the '-l 79 -S' flags. A future change will ignore this commit in git-blame history by adding a 'git-blame-ignore-revs' file. Change-Id: Ic318617c67ab7ce6527f9016b759a1d4b0b80802 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
1 parent 28ffa2b commit 35ba1d8

84 files changed

Lines changed: 5339 additions & 4438 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

openstackclient/tests/functional/volume/base.py

Lines changed: 37 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,18 @@
1616

1717

1818
class BaseVolumeTests(base.TestCase):
19-
"""Base class for Volume functional tests. """
19+
"""Base class for Volume functional tests."""
2020

2121
@classmethod
22-
def wait_for_status(cls, check_type, check_name, desired_status,
23-
wait=120, interval=5, failures=None):
22+
def wait_for_status(
23+
cls,
24+
check_type,
25+
check_name,
26+
desired_status,
27+
wait=120,
28+
interval=5,
29+
failures=None,
30+
):
2431
current_status = "notset"
2532
if failures is None:
2633
failures = ['error']
@@ -32,23 +39,31 @@ def wait_for_status(cls, check_type, check_name, desired_status,
3239
)
3340
current_status = output['status']
3441
if current_status == desired_status:
35-
print('{} {} now has status {}'
36-
.format(check_type, check_name, current_status))
42+
print(
43+
'{} {} now has status {}'.format(
44+
check_type, check_name, current_status
45+
)
46+
)
3747
return
38-
print('Checking {} {} Waiting for {} current status: {}'
39-
.format(check_type, check_name,
40-
desired_status, current_status))
48+
print(
49+
'Checking {} {} Waiting for {} current status: {}'.format(
50+
check_type, check_name, desired_status, current_status
51+
)
52+
)
4153
if current_status in failures:
4254
raise Exception(
43-
'Current status {} of {} {} is one of failures {}'
44-
.format(current_status, check_type, check_name, failures))
55+
'Current status {} of {} {} is one of failures {}'.format(
56+
current_status, check_type, check_name, failures
57+
)
58+
)
4559
time.sleep(interval)
4660
total_sleep += interval
4761
cls.assertOutput(desired_status, current_status)
4862

4963
@classmethod
50-
def wait_for_delete(cls, check_type, check_name, wait=120, interval=5,
51-
name_field=None):
64+
def wait_for_delete(
65+
cls, check_type, check_name, wait=120, interval=5, name_field=None
66+
):
5267
total_sleep = 0
5368
name_field = name_field or 'Name'
5469
while total_sleep < wait:
@@ -57,9 +72,15 @@ def wait_for_delete(cls, check_type, check_name, wait=120, interval=5,
5772
if check_name not in names:
5873
print('{} {} is now deleted'.format(check_type, check_name))
5974
return
60-
print('Checking {} {} Waiting for deleted'
61-
.format(check_type, check_name))
75+
print(
76+
'Checking {} {} Waiting for deleted'.format(
77+
check_type, check_name
78+
)
79+
)
6280
time.sleep(interval)
6381
total_sleep += interval
64-
raise Exception('Timeout: {} {} was not deleted in {} seconds'
65-
.format(check_type, check_name, wait))
82+
raise Exception(
83+
'Timeout: {} {} was not deleted in {} seconds'.format(
84+
check_type, check_name, wait
85+
)
86+
)

openstackclient/tests/functional/volume/v1/test_qos.py

Lines changed: 20 additions & 52 deletions
Original file line numberDiff line numberDiff line change
@@ -16,31 +16,23 @@
1616

1717

1818
class QosTests(common.BaseVolumeTests):
19-
"""Functional tests for volume qos. """
19+
"""Functional tests for volume qos."""
2020

2121
def test_volume_qos_create_list(self):
2222
"""Test create, list, delete multiple"""
2323
name1 = uuid.uuid4().hex
2424
cmd_output = self.openstack(
25-
'volume qos create ' +
26-
name1,
25+
'volume qos create ' + name1,
2726
parse_output=True,
2827
)
29-
self.assertEqual(
30-
name1,
31-
cmd_output['name']
32-
)
28+
self.assertEqual(name1, cmd_output['name'])
3329

3430
name2 = uuid.uuid4().hex
3531
cmd_output = self.openstack(
36-
'volume qos create ' +
37-
name2,
32+
'volume qos create ' + name2,
3833
parse_output=True,
3934
)
40-
self.assertEqual(
41-
name2,
42-
cmd_output['name']
43-
)
35+
self.assertEqual(name2, cmd_output['name'])
4436

4537
# Test list
4638
cmd_output = self.openstack(
@@ -60,67 +52,43 @@ def test_volume_qos_set_show_unset(self):
6052

6153
name = uuid.uuid4().hex
6254
cmd_output = self.openstack(
63-
'volume qos create ' +
64-
'--consumer front-end '
65-
'--property Alpha=a ' +
66-
name,
55+
'volume qos create ' + '--consumer front-end '
56+
'--property Alpha=a ' + name,
6757
parse_output=True,
6858
)
6959
self.addCleanup(self.openstack, 'volume qos delete ' + name)
70-
self.assertEqual(
71-
name,
72-
cmd_output['name']
73-
)
60+
self.assertEqual(name, cmd_output['name'])
7461

75-
self.assertEqual(
76-
"front-end",
77-
cmd_output['consumer']
78-
)
62+
self.assertEqual("front-end", cmd_output['consumer'])
7963

8064
# Test volume qos set
8165
raw_output = self.openstack(
82-
'volume qos set ' +
83-
'--property Alpha=c ' +
84-
'--property Beta=b ' +
85-
name,
66+
'volume qos set '
67+
+ '--property Alpha=c '
68+
+ '--property Beta=b '
69+
+ name,
8670
)
8771
self.assertOutput('', raw_output)
8872

8973
# Test volume qos show
9074
cmd_output = self.openstack(
91-
'volume qos show ' +
92-
name,
75+
'volume qos show ' + name,
9376
parse_output=True,
9477
)
95-
self.assertEqual(
96-
name,
97-
cmd_output['name']
98-
)
99-
self.assertEqual(
100-
{'Alpha': 'c', 'Beta': 'b'},
101-
cmd_output['properties']
102-
)
78+
self.assertEqual(name, cmd_output['name'])
79+
self.assertEqual({'Alpha': 'c', 'Beta': 'b'}, cmd_output['properties'])
10380

10481
# Test volume qos unset
10582
raw_output = self.openstack(
106-
'volume qos unset ' +
107-
'--property Alpha ' +
108-
name,
83+
'volume qos unset ' + '--property Alpha ' + name,
10984
)
11085
self.assertOutput('', raw_output)
11186

11287
cmd_output = self.openstack(
113-
'volume qos show ' +
114-
name,
88+
'volume qos show ' + name,
11589
parse_output=True,
11690
)
117-
self.assertEqual(
118-
name,
119-
cmd_output['name']
120-
)
121-
self.assertEqual(
122-
{'Beta': 'b'},
123-
cmd_output['properties']
124-
)
91+
self.assertEqual(name, cmd_output['name'])
92+
self.assertEqual({'Beta': 'b'}, cmd_output['properties'])
12593

12694
# TODO(qiangjiahui): Add tests for associate and disassociate volume type

openstackclient/tests/functional/volume/v1/test_service.py

Lines changed: 13 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -24,22 +24,16 @@ def test_volume_service_list(self):
2424

2525
# Test volume service list --service
2626
cmd_output = self.openstack(
27-
'volume service list ' +
28-
'--service ' +
29-
services[0],
27+
'volume service list ' + '--service ' + services[0],
3028
parse_output=True,
3129
)
3230
for x in cmd_output:
33-
self.assertEqual(
34-
services[0],
35-
x['Binary']
36-
)
31+
self.assertEqual(services[0], x['Binary'])
3732

3833
# TODO(zhiyong.dai): test volume service list --host after solving
3934
# https://bugs.launchpad.net/python-openstackclient/+bug/1664451
4035

4136
def test_volume_service_set(self):
42-
4337
# Get a service and host
4438
cmd_output = self.openstack(
4539
'volume service list',
@@ -50,42 +44,33 @@ def test_volume_service_set(self):
5044

5145
# Test volume service set --enable
5246
raw_output = self.openstack(
53-
'volume service set --enable ' +
54-
host_1 + ' ' +
55-
service_1
47+
'volume service set --enable ' + host_1 + ' ' + service_1
5648
)
5749
self.assertOutput('', raw_output)
5850

5951
cmd_output = self.openstack(
6052
'volume service list --long',
6153
parse_output=True,
6254
)
63-
self.assertEqual(
64-
'enabled',
65-
cmd_output[0]['Status']
66-
)
55+
self.assertEqual('enabled', cmd_output[0]['Status'])
6756
self.assertIsNone(cmd_output[0]['Disabled Reason'])
6857

6958
# Test volume service set --disable and --disable-reason
7059
disable_reason = 'disable_reason'
7160
raw_output = self.openstack(
72-
'volume service set --disable ' +
73-
'--disable-reason ' +
74-
disable_reason + ' ' +
75-
host_1 + ' ' +
76-
service_1
61+
'volume service set --disable '
62+
+ '--disable-reason '
63+
+ disable_reason
64+
+ ' '
65+
+ host_1
66+
+ ' '
67+
+ service_1
7768
)
7869
self.assertOutput('', raw_output)
7970

8071
cmd_output = self.openstack(
8172
'volume service list --long',
8273
parse_output=True,
8374
)
84-
self.assertEqual(
85-
'disabled',
86-
cmd_output[0]['Status']
87-
)
88-
self.assertEqual(
89-
disable_reason,
90-
cmd_output[0]['Disabled Reason']
91-
)
75+
self.assertEqual('disabled', cmd_output[0]['Status'])
76+
self.assertEqual(disable_reason, cmd_output[0]['Disabled Reason'])

0 commit comments

Comments
 (0)