Skip to content

Commit 2a2a6e1

Browse files
committed
trivial: Make better use of argparse
Change-Id: Ib76c0d18bf5e44bfb4dcd9d729d9a1c5635cdba7 Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
1 parent a3410cd commit 2a2a6e1

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

openstackclient/tests/unit/volume/v2/test_volume_type.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -173,6 +173,7 @@ def test_public_type_create_with_project_public(self):
173173
self.new_volume_type.name,
174174
]
175175
verifylist = [
176+
('is_public', None),
176177
('project', self.project.id),
177178
('name', self.new_volume_type.name),
178179
]

openstackclient/volume/v2/volume_type.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,11 +250,14 @@ def take_action(self, parsed_args):
250250
raise exceptions.CommandError(msg)
251251

252252
kwargs = {}
253+
253254
if parsed_args.is_public is not None:
254255
kwargs['is_public'] = parsed_args.is_public
255256

256257
volume_type = volume_client.volume_types.create(
257-
parsed_args.name, description=parsed_args.description, **kwargs
258+
parsed_args.name,
259+
description=parsed_args.description,
260+
**kwargs,
258261
)
259262
volume_type._info.pop('extra_specs')
260263

0 commit comments

Comments
 (0)