Skip to content

Commit f0247ed

Browse files
committed
Move xtrace early
I dug back through the history to see why xtrace is enabled where it is. Originally (like first commit originally), it was somewhat sanely placed to turn on tracing after it had done the interactive "read_password" prompt stuff. Over time, it has just shuffled it's way down as stuff got added around it. This was noticed this because I was looking for tracing of earlier commands when looking at the repo setup (see Iec2ad7b5598fdaefbc2338ade702bc7b08963b96) and couldn't find it. Putting this at the start means we both capture all output unconditionally, and avoid needlessly getting this interleaved at some odd place again. Change-Id: I441d7eecbab9d204258c18a071ccc1cbf4f7512a
1 parent 2d25c92 commit f0247ed

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

stack.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,10 @@
2121

2222
# Learn more and get the most recent version at http://devstack.org
2323

24+
# Print the commands being run so that we can see the command that triggers
25+
# an error. It is also useful for following along as the install occurs.
26+
set -o xtrace
27+
2428
# Make sure custom grep options don't get in the way
2529
unset GREP_OPTIONS
2630

@@ -485,10 +489,6 @@ function err_trap {
485489
# Begin trapping error exit codes
486490
set -o errexit
487491

488-
# Print the commands being run so that we can see the command that triggers
489-
# an error. It is also useful for following along as the install occurs.
490-
set -o xtrace
491-
492492
# Print the kernel version
493493
uname -a
494494

0 commit comments

Comments
 (0)