Remove API_RATE_LIMIT variable since it's wrong anyway

The api_rate_limit config option in nova has defaulted to False since
Havana per commit cfdc59860ef1482e3b064f90f719ec9e484590ce. This change
removes the variable and code that's used to set it in nova.conf since
if we left it in we'd change the default to False to match the code, and
we'd be breaking anyone that is relying on this to be True anyway.

Note that this variable exists in devstack essentially for Tempest so we
can set it in devstack-gate, which is kind of a moot point now given the
code defaults to it anyway.

Change I21dbd72f9959a4e3d62c36831df03b351a51172e removes it from
devstack-gate.

Change-Id: Ib0538bdd23b17e519b9c917018ccc9fa8c6425c5

Author: Matt Riedemann

lib/nova

@@ -59,10 +59,6 @@ fi
 # Set the paths of certain binaries
 NOVA_ROOTWRAP=$(get_rootwrap_location nova)
 
-# Allow rate limiting to be turned off for testing, like for Tempest
-# NOTE: Set API_RATE_LIMIT="False" to turn OFF rate limiting
-API_RATE_LIMIT=${API_RATE_LIMIT:-"True"}
-
 # Option to enable/disable config drive
 # NOTE: Set FORCE_CONFIG_DRIVE="False" to turn OFF config drive
 FORCE_CONFIG_DRIVE=${FORCE_CONFIG_DRIVE:-"always"}
@@ -461,9 +457,6 @@ function create_nova_conf {
     if [ "$SYSLOG" != "False" ]; then
         iniset $NOVA_CONF DEFAULT use_syslog "True"
     fi
-    if [ "$API_RATE_LIMIT" != "True" ]; then
-        iniset $NOVA_CONF DEFAULT api_rate_limit "False"
-    fi
     if [ "$FORCE_CONFIG_DRIVE" != "False" ]; then
         iniset $NOVA_CONF DEFAULT force_config_drive "$FORCE_CONFIG_DRIVE"
     fi