Skip to content

Commit aae311a

Browse files
Zuulopenstack-gerrit
authored andcommitted
Merge "Only modify folders created by devstack"
2 parents b9f4a73 + 352d58a commit aae311a

3 files changed

Lines changed: 25 additions & 6 deletions

File tree

roles/setup-devstack-log-dir/tasks/main.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,7 @@
22
file:
33
path: '{{ devstack_base_dir }}/logs'
44
state: directory
5+
mode: 0755
6+
owner: stack
7+
group: stack
58
become: yes

roles/sync-devstack-data/tasks/main.yaml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,3 +46,14 @@
4646
dest: "{{ devstack_data_base_dir }}/data/"
4747
mode: push
4848
when: 'inventory_hostname in groups["subnode"]|default([])'
49+
50+
- name: Ensure the data folder and subfolders have the correct permissions
51+
become: true
52+
file:
53+
path: "{{ devstack_data_base_dir }}/data"
54+
state: directory
55+
owner: stack
56+
group: stack
57+
mode: 0755
58+
recurse: yes
59+
when: 'inventory_hostname in groups["subnode"]|default([])'

stack.sh

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -365,9 +365,12 @@ DEST=${DEST:-/opt/stack}
365365

366366
# Create the destination directory and ensure it is writable by the user
367367
# and read/executable by everybody for daemons (e.g. apache run for horizon)
368-
sudo mkdir -p $DEST
369-
safe_chown -R $STACK_USER $DEST
370-
safe_chmod 0755 $DEST
368+
# If directory exists do not modify the permissions.
369+
if [[ ! -d $DEST ]]; then
370+
sudo mkdir -p $DEST
371+
safe_chown -R $STACK_USER $DEST
372+
safe_chmod 0755 $DEST
373+
fi
371374

372375
# Destination path for devstack logs
373376
if [[ -n ${LOGDIR:-} ]]; then
@@ -376,9 +379,11 @@ fi
376379

377380
# Destination path for service data
378381
DATA_DIR=${DATA_DIR:-${DEST}/data}
379-
sudo mkdir -p $DATA_DIR
380-
safe_chown -R $STACK_USER $DATA_DIR
381-
safe_chmod 0755 $DATA_DIR
382+
if [[ ! -d $DATA_DIR ]]; then
383+
sudo mkdir -p $DATA_DIR
384+
safe_chown -R $STACK_USER $DATA_DIR
385+
safe_chmod 0755 $DATA_DIR
386+
fi
382387

383388
# Configure proper hostname
384389
# Certain services such as rabbitmq require that the local hostname resolves

0 commit comments

Comments
 (0)