Skip to content

Commit a7a2b88

Browse files
Jenkinsopenstack-gerrit
authored andcommitted
Merge "Add and document $NOVA_VNC_ENABLED for forcing VNC on"
2 parents 11d6bde + 4e07fdc commit a7a2b88

2 files changed

Lines changed: 12 additions & 2 deletions

File tree

docs/source/guides/multinode-lab.html

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,13 @@ <h3>Configure Compute Nodes</h3>
184184
MYSQL_HOST=192.168.42.11
185185
RABBIT_HOST=192.168.42.11
186186
GLANCE_HOSTPORT=192.168.42.11:9292
187-
ENABLED_SERVICES=n-cpu,n-net,n-api,c-sch,c-api,c-vol</pre>
187+
ENABLED_SERVICES=n-cpu,n-net,n-api,c-sch,c-api,c-vol
188+
NOVA_VNC_ENABLED=True
189+
NOVNCPROXY_URL="http://192.168.42.11:6080/vnc_auto.html"
190+
VNCSERVER_LISTEN=$HOST_IP
191+
VNCSERVER_PROXYCLIENT_ADDRESS=$VNCSERVER_LISTEN
192+
</pre>
193+
188194
<!-- save for vlan
189195
FLAT_INTERFACE=eth0.926
190196
-->

lib/nova

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,10 @@ GUEST_INTERFACE_DEFAULT=$(ip link \
8484
| grep ^[ep] \
8585
| head -1)
8686

87+
# $NOVA_VNC_ENABLED can be used to forcibly enable vnc configuration.
88+
# In multi-node setups allows compute hosts to not run n-novnc.
89+
NOVA_VNC_ENABLED=$(trueorfalse False $NOVA_VNC_ENABLED)
90+
8791
# Get hypervisor configuration
8892
# ----------------------------
8993

@@ -485,7 +489,7 @@ function create_nova_conf {
485489
iniset $NOVA_CONF spice html5proxy_base_url "$SPICEHTML5PROXY_URL"
486490
fi
487491

488-
if is_service_enabled n-novnc || is_service_enabled n-xvnc; then
492+
if is_service_enabled n-novnc || is_service_enabled n-xvnc || [ "$NOVA_VNC_ENABLED" != False ]; then
489493
# Address on which instance vncservers will listen on compute hosts.
490494
# For multi-host, this should be the management ip of the compute host.
491495
VNCSERVER_LISTEN=${VNCSERVER_LISTEN=127.0.0.1}

0 commit comments

Comments
 (0)