Skip to content

Commit 5888947

Browse files
committed
Clean up compile_ovn function's parameters
That function was accepting 3 positional arguments and first of them was boolean value "build_modules" which isn't used anywhere in that function. So this patch cleans it a bit by removing that not used parameter. Change-Id: I5c57b9116338a63b7bfb170c02e33bb4eae725da
1 parent 6c849e3 commit 5888947

1 file changed

Lines changed: 5 additions & 8 deletions

File tree

lib/neutron_plugins/ovn_agent

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -294,16 +294,13 @@ function _disable_libvirt_apparmor {
294294

295295
# compile_ovn() - Compile OVN from source and load needed modules
296296
# Accepts three parameters:
297-
# - first optional is False by default and means that
298-
# modules are built and installed.
299-
# - second optional parameter defines prefix for
297+
# - first optional parameter defines prefix for
300298
# ovn compilation
301-
# - third optional parameter defines localstatedir for
299+
# - second optional parameter defines localstatedir for
302300
# ovn single machine runtime
303301
function compile_ovn {
304-
local build_modules=${1:-False}
305-
local prefix=$2
306-
local localstatedir=$3
302+
local prefix=$1
303+
local localstatedir=$2
307304

308305
if [ -n "$prefix" ]; then
309306
prefix="--prefix=$prefix"
@@ -381,7 +378,7 @@ function install_ovn {
381378

382379
compile_ovs $OVN_BUILD_MODULES
383380
if use_new_ovn_repository; then
384-
compile_ovn $OVN_BUILD_MODULES
381+
compile_ovn
385382
fi
386383

387384
sudo mkdir -p $OVS_PREFIX/var/log/openvswitch

0 commit comments

Comments
 (0)