Skip to content

Commit 856f6d5

Browse files
kquinn1204claude
andcommitted
TELCODOCS-2853: Fix AsciiDocDITA violations for hardware offloading docs
Resolve all Vale AsciiDocDITA errors and warnings to prepare the configuring-hardware-offloading assembly and its modules for DITA conversion. Changes include adding short descriptions, replacing callouts with bullet lists, extracting inline prerequisites to a new module, fixing terminology, and correcting content type. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 4f5eb91 commit 856f6d5

11 files changed

Lines changed: 97 additions & 48 deletions

modules/nw-sriov-hwol-about-hardware-offloading.adoc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
[id="about-hardware-offloading_{context}"]
77
= About hardware offloading
88

9+
[role="_abstract"]
910
Open vSwitch hardware offloading is a method of processing network tasks by diverting them away from the CPU and offloading them to a dedicated processor on a network interface controller.
1011
As a result, clusters can benefit from faster data transfer speeds, reduced CPU workloads, and lower computing costs.
1112

@@ -14,7 +15,7 @@ A SmartNIC is a network interface controller that is able to handle computationa
1415
In the same way that a dedicated graphics card can improve graphics performance, a SmartNIC can improve network performance.
1516
In each case, a dedicated processor improves performance for a specific type of processing task.
1617

17-
In {product-title}, you can configure hardware offloading for bare metal nodes that have a compatible SmartNIC.
18+
In {product-title}, you can configure hardware offloading for bare-metal nodes that have a compatible SmartNIC.
1819
Hardware offloading is configured and enabled by the SR-IOV Network Operator.
1920

2021
Hardware offloading is not compatible with all workloads or application types.

modules/nw-sriov-hwol-adding-network-attachment-definitions-to-pods.adoc

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
[id="adding-network-attachment-definition-to-pods_{context}"]
77
= Adding the network attachment definition to your pods
88

9+
[role="_abstract"]
910
After you create the machine config pool, the `SriovNetworkPoolConfig` and `SriovNetworkNodePolicy` custom resources, and the network attachment definition, you can apply these configurations to your pods by adding the network attachment definition to your pod specifications.
1011

1112
.Procedure
@@ -17,6 +18,9 @@ After you create the machine config pool, the `SriovNetworkPoolConfig` and `Srio
1718
....
1819
metadata:
1920
annotations:
20-
v1.multus-cni.io/default-network: net-attach-def/net-attach-def <1>
21+
v1.multus-cni.io/default-network: <namespace>/<net_attach_def_name>
2122
----
22-
<1> The value must be the name and namespace of the network attachment definition you created for hardware offloading.
23+
+
24+
--
25+
* `<namespace>/<net_attach_def_name>` specifies the namespace and name of the network attachment definition you created for hardware offloading.
26+
--

modules/nw-sriov-hwol-configuring-machine-config-pool.adoc

Lines changed: 17 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
[id="configuring-machine-config-pool_{context}"]
77
= Configuring a machine config pool for hardware offloading
88

9+
[role="_abstract"]
910
To enable hardware offloading, you now create a dedicated machine config pool and configure it to work with the SR-IOV Network Operator.
1011

1112
.Prerequisites
@@ -16,24 +17,26 @@ To enable hardware offloading, you now create a dedicated machine config pool an
1617

1718
. Create a machine config pool for machines you want to use hardware offloading on.
1819

19-
.. Create a file, such as `mcp-offloading.yaml`, with content like the following example:
20+
.. Create a file, such as `mcp-offloading.yaml`, with content such as the following example:
2021
+
2122
[source,yaml]
2223
----
2324
apiVersion: machineconfiguration.openshift.io/v1
2425
kind: MachineConfigPool
2526
metadata:
26-
name: mcp-offloading <1>
27+
name: <mcp_name>
2728
spec:
2829
machineConfigSelector:
2930
matchExpressions:
30-
- {key: machineconfiguration.openshift.io/role, operator: In, values: [worker,mcp-offloading]} <1>
31+
- {key: machineconfiguration.openshift.io/role, operator: In, values: [worker,<mcp_name>]}
3132
nodeSelector:
3233
matchLabels:
33-
node-role.kubernetes.io/mcp-offloading: "" <2>
34+
node-role.kubernetes.io/<mcp_name>: ""
3435
----
35-
<1> The name of your machine config pool for hardware offloading.
36-
<2> This node role label is used to add nodes to the machine config pool.
36+
+
37+
--
38+
* `<mcp_name>` specifies the name of your machine config pool for hardware offloading. This value is used as the machine config pool name, the machine config selector value, and the node role label.
39+
--
3740

3841
.. Apply the configuration for the machine config pool:
3942
+
@@ -57,7 +60,8 @@ $ oc get nodes
5760
----
5861
+
5962
--
60-
.Example output
63+
The following is example output:
64+
6165
[source,terminal]
6266
----
6367
NAME STATUS ROLES AGE VERSION
@@ -71,7 +75,7 @@ worker-2 Ready mcp-offloading,worker 47h v1.34.2
7175

7276
. Add this machine config pool to the `SriovNetworkPoolConfig` custom resource:
7377

74-
.. Create a file, such as `sriov-pool-config.yaml`, with content like the following example:
78+
.. Create a file, such as `sriov-pool-config.yaml`, with content such as the following example:
7579
+
7680
[source,yaml]
7781
----
@@ -82,9 +86,12 @@ metadata:
8286
namespace: openshift-sriov-network-operator
8387
spec:
8488
ovsHardwareOffloadConfig:
85-
name: mcp-offloading <1>
89+
name: <mcp_name>
8690
----
87-
<1> The name of your machine config pool for hardware offloading.
91+
+
92+
--
93+
* `<mcp_name>` specifies the name of your machine config pool for hardware offloading.
94+
--
8895

8996
.. Apply the configuration:
9097
+

modules/nw-sriov-hwol-configuring-systemd-mode.adoc

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
[id="nw-sriov-hwol-configuring-systemd-mode_{context}"]
77
= Setting the SR-IOV Network Operator into systemd mode
88

9+
[role="_abstract"]
910
To support hardware offloading, you must first set the SR-IOV Network Operator into `systemd` mode.
1011

1112
.Prerequisites
@@ -24,17 +25,19 @@ To support hardware offloading, you must first set the SR-IOV Network Operator i
2425
apiVersion: sriovnetwork.openshift.io/v1
2526
kind: SriovOperatorConfig
2627
metadata:
27-
name: default <1>
28+
name: default
2829
namespace: openshift-sriov-network-operator
2930
spec:
3031
enableInjector: true
3132
enableOperatorWebhook: true
32-
configurationMode: "systemd" <2>
33+
configurationMode: "systemd"
3334
logLevel: 2
3435
----
3536
+
36-
<1> The only valid name for the `SriovOperatorConfig` resource is `default` and it must be in the namespace where the Operator is deployed.
37-
<2> Setting the SR-IOV Network Operator into `systemd` mode is only relevant for Open vSwitch hardware offloading.
37+
--
38+
* The only valid name for the `SriovOperatorConfig` resource is `default` and it must be in the namespace where the Operator is deployed.
39+
* Setting the SR-IOV Network Operator into `systemd` mode is only relevant for Open vSwitch hardware offloading.
40+
--
3841

3942
.. Create the resource by running the following command:
4043
+

modules/nw-sriov-hwol-creating-network-attachment-definition.adoc

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@
66
[id="create-network-attachment-definition_{context}"]
77
= Creating a network attachment definition
88

9-
After you define the machine config pool and the SR-IOV network node policy, you can create a network attachment definition for the network interface card you specified.
9+
[role="_abstract"]
10+
After you define the machine config pool and the SR-IOV network node policy, you can create a network attachment definition for the network interface controller (NIC) you specified.
1011

1112
.Prerequisites
1213

@@ -15,23 +16,26 @@ After you define the machine config pool and the SR-IOV network node policy, you
1516
1617
.Procedure
1718

18-
. Create a file, such as `net-attach-def.yaml`, with content like the following example:
19+
. Create a file, such as `net-attach-def.yaml`, with content such as the following example:
1920
+
2021
[source,yaml]
2122
----
2223
apiVersion: "k8s.cni.cncf.io/v1"
2324
kind: NetworkAttachmentDefinition
2425
metadata:
25-
name: net-attach-def <1>
26-
namespace: net-attach-def <2>
26+
name: <net_attach_def_name>
27+
namespace: <net_attach_def_namespace>
2728
annotations:
28-
k8s.v1.cni.cncf.io/resourceName: openshift.io/mlxnics <3>
29+
k8s.v1.cni.cncf.io/resourceName: openshift.io/<resource_name>
2930
spec:
3031
config: '{"cniVersion":"0.3.1","name":"ovn-kubernetes","type":"ovn-k8s-cni-overlay","ipam":{},"dns":{}}'
3132
----
32-
<1> The name for your network attachment definition.
33-
<2> The namespace for your network attachment definition.
34-
<3> This is the value of the `spec.resourceName` field you specified in the `SriovNetworkNodePolicy` object.
33+
+
34+
--
35+
* `<net_attach_def_name>` specifies the name for your network attachment definition.
36+
* `<net_attach_def_namespace>` specifies the namespace for your network attachment definition.
37+
* `<resource_name>` specifies the value of the `spec.resourceName` field from the `SriovNetworkNodePolicy` object.
38+
--
3539

3640
. Apply the configuration for the network attachment definition:
3741
+

modules/nw-sriov-hwol-creating-sriov-policy.adoc

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
[id="configure-sriov-node-policy_{context}"]
77
= Configuring the SR-IOV network node policy
88

9+
[role="_abstract"]
910
You can create an SR-IOV network device configuration for a node by creating an SR-IOV network node policy.
1011
To enable hardware offloading, you must define the `.spec.eSwitchMode` field with the value `"switchdev"`.
1112

@@ -18,18 +19,18 @@ The following procedure creates an SR-IOV interface for a network interface cont
1819
1920
.Procedure
2021

21-
. Create a file, such as `sriov-node-policy.yaml`, with content like the following example:
22+
. Create a file, such as `sriov-node-policy.yaml`, with content such as the following example:
2223
+
2324
[source,yaml]
2425
----
2526
apiVersion: sriovnetwork.openshift.io/v1
2627
kind: SriovNetworkNodePolicy
2728
metadata:
28-
name: sriov-node-policy <1>
29+
name: <name>
2930
namespace: openshift-sriov-network-operator
3031
spec:
31-
deviceType: netdevice <2>
32-
eSwitchMode: "switchdev" <3>
32+
deviceType: netdevice
33+
eSwitchMode: "switchdev"
3334
nicSelector:
3435
deviceID: "1019"
3536
rootDevices:
@@ -43,9 +44,12 @@ spec:
4344
priority: 5
4445
resourceName: mlxnics
4546
----
46-
<1> The name for the custom resource object.
47-
<2> Required. Hardware offloading is not supported with `vfio-pci`.
48-
<3> Required.
47+
+
48+
--
49+
* `<name>` specifies the name for the custom resource object.
50+
* The `deviceType` field must be set to `netdevice`. Hardware offloading is not supported with `vfio-pci`.
51+
* The `eSwitchMode` field must be set to `"switchdev"`.
52+
--
4953

5054
. Apply the configuration for the policy:
5155
+

modules/nw-sriov-hwol-improving-network-traffic-performance.adoc

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
[id="improving-network-traffic-performance-using-vf_{context}"]
77
= Improving network traffic performance using a virtual function
88

9+
[role="_abstract"]
910
Follow this procedure to assign a virtual function to the OVN-Kubernetes management port and increase its network traffic performance.
1011

1112
This procedure results in the creation of two pools: the first has a virtual function used by OVN-Kubernetes, and the second comprises the remaining virtual functions.
@@ -44,15 +45,18 @@ spec:
4445
- 0000:d8:00.0
4546
vendor: "15b3"
4647
pfNames:
47-
- ens8f0#0-0 <1>
48+
- <pf_name>#0-0
4849
nodeSelector:
4950
network.operator.openshift.io/smart-nic: ""
50-
numVfs: 6 <2>
51+
numVfs: <num_vfs>
5152
priority: 5
5253
resourceName: mgmtvf
5354
----
54-
<1> Replace this device with the appropriate network device for your use case. The `#0-0` part of the `pfNames` value reserves a single virtual function used by OVN-Kubernetes.
55-
<2> The value provided here is an example. Replace this value with one that meets your requirements. For more information, see _SR-IOV network node configuration object_ in the _Additional resources_ section.
55+
+
56+
--
57+
* `<pf_name>` specifies the network device for your use case. The `#0-0` part of the `pfNames` value reserves a single virtual function used by OVN-Kubernetes.
58+
* `<num_vfs>` specifies the number of virtual functions. Replace this value with one that meets your requirements. For more information, see _SR-IOV network node configuration object_ in the _Additional resources_ section.
59+
--
5660

5761
. Create a policy named `sriov-node-policy.yaml` with content such as the following example:
5862
+
@@ -72,15 +76,18 @@ spec:
7276
- 0000:d8:00.0
7377
vendor: "15b3"
7478
pfNames:
75-
- ens8f0#1-5 <1>
79+
- <pf_name>#1-5
7680
nodeSelector:
7781
network.operator.openshift.io/smart-nic: ""
78-
numVfs: 6 <2>
82+
numVfs: <num_vfs>
7983
priority: 5
8084
resourceName: mlxnics
8185
----
82-
<1> Replace this device with the appropriate network device for your use case.
83-
<2> The value provided here is an example. Replace this value with the value specified in the `sriov-node-mgmt-vf-policy.yaml` file. For more information, see _SR-IOV network node configuration object_ in the _Additional resources_ section.
86+
+
87+
--
88+
* `<pf_name>` specifies the network device for your use case.
89+
* `<num_vfs>` specifies the number of virtual functions. Replace this value with the value specified in the `sriov-node-mgmt-vf-policy.yaml` file. For more information, see _SR-IOV network node configuration object_ in the _Additional resources_ section.
90+
--
8491
+
8592
[NOTE]
8693
====
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
// Module included in the following assemblies:
2+
//
3+
// * networking/hardware_networks/configuring-hardware-offloading.adoc
4+
5+
:_mod-docs-content-type: REFERENCE
6+
[id="configuring-hardware-offloading-prerequisites_{context}"]
7+
= Prerequisites
8+
9+
[role="_abstract"]
10+
Before you configure hardware offloading, ensure that the following conditions are met.
11+
12+
* Your cluster has at least one bare-metal machine with a network interface controller that is supported for hardware offloading.
13+
* You installed the SR-IOV Network Operator.
14+
* Your cluster uses the OVN-Kubernetes network plugin.
15+
* In your OVN-Kubernetes network plugin configuration, the `gatewayConfig.routingViaHost` field is set to `false`.

modules/nw-sriov-hwol-ref-openstack-sriov-policy.adoc

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,15 @@
22
//
33
// * networking/configuring-hardware-offloading.adoc
44

5-
:_mod-docs-content-type: PROCEDURE
5+
:_mod-docs-content-type: REFERENCE
66
[id="nw-sriov-hwol-ref-openstack-sriov-policy_{context}"]
77
= An example SR-IOV network node policy for OpenStack
88

9+
[role="_abstract"]
910
The following example describes an SR-IOV interface for a network interface controller (NIC) with hardware offloading on {rh-openstack-first}.
1011

11-
.An SR-IOV interface for a NIC with hardware offloading on {rh-openstack}
12+
The following example shows an SR-IOV interface for a NIC with hardware offloading on {rh-openstack}:
13+
1214
[source,yaml]
1315
----
1416
apiVersion: sriovnetwork.openshift.io/v1

modules/nw-sriov-hwol-supported-devices.adoc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
[id="supported_devices_{context}"]
77
= Supported devices
88

9+
[role="_abstract"]
910
Hardware offloading is supported on the following network interface controllers:
1011

1112
.Supported network interface controllers

0 commit comments

Comments
 (0)