NO-JIRA: Rename AppRole datakeys to role-id and secret-id

[ardaguclu]

This PR fixes AppRole Secret datakeys to align with #2212

Summary by CodeRabbit

• Bug Fixes
  • Updated AppRole credential key format in Kubernetes Secrets from camelCase to hyphenated format (role-id, secret-id). This standardizes the secret data structure for Vault AppRole consumers.

[openshift-ci-robot]

@ardaguclu: This pull request explicitly references no jira issue.

Details

In response to this:

This PR fixes AppRole Secret datakeys to align with #2212

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: ebfeeb76-76d1-47d3-ba34-4d31a3e97712

📥 Commits

Reviewing files that changed from the base of the PR and between c83b770 and 39bd430.

📒 Files selected for processing (1)

• test/library/encryption/kms/vault.go

---

Walkthrough

This PR updates a test fixture in vault.go that generates Vault AppRole Secrets for Kubernetes. The credential data keys in the generated Secret are changed from camelCase format (roleID, secretID) to hyphenated format (role-id, secret-id).

Changes

AppRole Secret Key Format

Layer / File(s)	Summary
AppRole Secret data key format test/library/encryption/kms/vault.go	The ensureDefaultVaultAppRoleSecret test helper updates the generated Secret's credential data keys from camelCase ("roleID", "secretID") to hyphenated names ("role-id", "secret-id"), aligning the test fixture with the expected Kubernetes Secret data structure.

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely summarizes the main change: renaming AppRole datakeys from camelCase to hyphenated format, which matches the actual changeset.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The modified file contains no Ginkgo test definitions. It only has helper functions, so the stable test names check does not apply.
Test Structure And Quality	✅ Passed	The modified file test/library/encryption/kms/vault.go contains no Ginkgo tests (only helper functions using testify/require), making the "Test Structure and Quality" check inapplicable to this PR.
Microshift Test Compatibility	✅ Passed	PR does not add new Ginkgo e2e tests. The change modifies a helper function in a utility file (test/library/encryption/kms/vault.go), not test declarations.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR does not add new Ginkgo e2e tests; only modifies a test library helper function that changes AppRole Secret data keys.
Topology-Aware Scheduling Compatibility	✅ Passed	PR modifies only test/library/encryption/kms/vault.go, a test helper file changing Secret datakeys. No deployment manifests, operator code, or scheduling constraints are introduced.
Ote Binary Stdout Contract	✅ Passed	PR modifies only test helper function ensureDefaultVaultAppRoleSecret (data map keys). No process-level code, no init functions, no stdout writes detected. OTE stdout contract not violated.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new Ginkgo e2e tests are added in this PR. The file is a library utility containing helper functions, and only configuration data keys are changed.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[ardaguclu]

/cc @bertinatto @p0lyn0mial @gangwgr

[openshift-ci]

@ardaguclu: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[gangwgr]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ardaguclu, gangwgr
Once this PR has been reviewed and has the lgtm label, please assign dgrisonnet for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• test/library/encryption/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment