DNM: Test https://review.opendev.org/c/openstack/ironic/+/985123 on PR821

[MahnoorAsghar]

Summary by CodeRabbit

• Chores
  • Updated two Git-based dependency pins to newer commits to incorporate upstream fixes and improvements.
  • No other dependency versions or constraints changed; change is low-risk and aims to improve stability.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 3b9e717d-23c1-4955-b5c0-40c546856669

📥 Commits

Reviewing files that changed from the base of the PR and between cb17eaf and 3bc4377.

📒 Files selected for processing (1)

• requirements.cachito

✅ Files skipped from review due to trivial changes (1)

• requirements.cachito

---

Walkthrough

Two git-based dependency pins in requirements.cachito were updated: ironic now points to the MahnoorAsghar/openstack-ironic fork at a new commit, and sushy was moved to a later commit hash in the openshift/openstack-sushy repository.

Changes

Cohort / File(s)	Summary
Dependency Source Pin Updates requirements.cachito	Updated two git dependency pins: ironic changed from openshift/openstack-ironic@f8686d3... to MahnoorAsghar/openstack-ironic@89804b4...; sushy advanced from openshift/openstack-sushy@5a6b97e... to openshift/openstack-sushy@6094f72....

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 9 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title references a specific OpenStack Ironic review (PR985123) and mentions PR821, which aligns with the changeset that pins ironic to a different fork and commit; however, it uses the 'DNM' (Do Not Merge) marker and includes a full URL, making it informal and not clearly summarizing the actual substantive changes to dependencies.	Consider using a clearer, more formal title that describes the dependency updates being tested, such as: 'Test ironic fork with timeout fix for PR821' or similar, removing the DNM marker and URL if this is intended as a permanent change.

✅ Passed checks (9 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names	✅ Passed	This PR only modifies requirements.cachito, a dependency configuration file. No test files or Ginkgo test names were modified.
Test Structure And Quality	✅ Passed	The custom check for Ginkgo test quality is not applicable to this pull request as the repository is Python and Dockerfile-based with no Ginkgo test files.
Microshift Test Compatibility	✅ Passed	PR modifies only Python requirements file with dependency pins; no Ginkgo e2e tests are added or modified.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This pull request does not add any Ginkgo e2e tests. It only updates Python dependency pins in requirements.cachito. The custom check is not applicable as no new tests are present.
Topology-Aware Scheduling Compatibility	✅ Passed	PR modifies requirements.cachito for ironic and sushy packages in openshift/ironic-image container build repository, not deployment manifests or operator code.
Ote Binary Stdout Contract	✅ Passed	PR modifies only requirements.cachito, a dependency specification file updating external package versions. No source code changes that could violate OTE Binary Stdout Contract.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This custom check only applies when new Ginkgo e2e tests are added. The PR does not introduce any Ginkgo e2e tests, only updates dependency pins and adds container configuration files.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MahnoorAsghar
Once this PR has been reviewed and has the lgtm label, please assign derekhiggins for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@requirements.cachito`:
- Line 1: The requirements.cachito entry pins the 'ironic' dependency to a
personal fork (MahnoorAsghar/openstack-ironic@18e0706f...), which must not be
merged; update the pin to use the approved upstream repository
(openshift/openstack-ironic) and the intended commit (or backport the commit to
that upstream repo) so the requirements.cachito line for the 'ironic' package
references openshift/openstack-ironic@<upstream-commit> instead of the personal
fork; ensure the chosen commit exists in openshift/openstack-ironic before
updating.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 842f44dc-79ce-4846-92f4-038d4fcc0e69

📥 Commits

Reviewing files that changed from the base of the PR and between 208ccd1 and cb17eaf.

📒 Files selected for processing (1)

• requirements.cachito

[coderabbitai]

⚠️ Potential issue | 🟠 Major

Personal fork pin must not be merged.

ironic is pinned to MahnoorAsghar/openstack-ironic, a personal fork. This is consistent with the PR being marked DNM, but flagging for visibility: before this PR can merge, the ironic source must be restored to openshift/openstack-ironic (with the intended upstream commit backported there). A personal fork as a build source is not acceptable for production image builds consumed by Dockerfile.ocp's wheel-builder stage.

🔧 Proposed revert before merge

-ironic @ git+https://github.com/MahnoorAsghar/openstack-ironic@18e0706f0420984aa5c424adbb08e357e7f82fec
+ironic @ git+https://github.com/openshift/openstack-ironic@<commit-sha-on-openshift-fork>

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@requirements.cachito` at line 1, The requirements.cachito entry pins the
'ironic' dependency to a personal fork
(MahnoorAsghar/openstack-ironic@18e0706f...), which must not be merged; update
the pin to use the approved upstream repository (openshift/openstack-ironic) and
the intended commit (or backport the commit to that upstream repo) so the
requirements.cachito line for the 'ironic' package references
openshift/openstack-ironic@<upstream-commit> instead of the personal fork;
ensure the chosen commit exists in openshift/openstack-ironic before updating.

[MahnoorAsghar]

Lets see if e2e-metal-ipi-bm passes here

[openshift-ci]

@MahnoorAsghar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/check-requirements	3bc4377	link	true	/test check-requirements

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.