Fix lint issues w/ legacy tests

Author: vr4manta

pkg/asset/installconfig/aws/validation_test.go

@@ -1520,10 +1520,8 @@ func TestValidate(t *testing.T) {
 			err := Validate(context.TODO(), meta, test.installConfig)
 			if test.expectErr == "" {
 				assert.NoError(t, err)
-			} else {
-				if assert.Error(t, err) {
-					assert.Regexp(t, test.expectErr, err.Error())
-				}
+			} else if assert.Error(t, err) {
+				assert.Regexp(t, test.expectErr, err.Error())
 			}
 		})
 	}
@@ -1651,10 +1649,8 @@ func TestValidateForProvisioning(t *testing.T) {
 			err := ValidateForProvisioning(t.Context(), route53Client, route53Client, ic, meta)
 			if test.expectedErr == "" {
 				assert.NoError(t, err)
-			} else {
-				if assert.Error(t, err) {
-					assert.Regexp(t, test.expectedErr, err.Error())
-				}
+			} else if assert.Error(t, err) {
+				assert.Regexp(t, test.expectedErr, err.Error())
 			}
 		})
 	}
@@ -1694,7 +1690,6 @@ func TestGetSubDomainDNSRecords(t *testing.T) {
 	route53Client := mock.NewMockRoute53API(mockCtrl)
 
 	for _, test := range cases {
-
 		t.Run(test.name, func(t *testing.T) {
 			ic := icBuild.build(icBuild.withBaseDomain(test.baseDomain))
 			if test.expectedErr != "" {
@@ -1719,10 +1714,8 @@ func TestGetSubDomainDNSRecords(t *testing.T) {
 			_, err := route53Client.GetSubDomainDNSRecords(t.Context(), &validDomainOutput, ic)
 			if test.expectedErr == "" {
 				assert.NoError(t, err)
-			} else {
-				if assert.Error(t, err) {
-					assert.Regexp(t, test.expectedErr, err.Error())
-				}
+			} else if assert.Error(t, err) {
+				assert.Regexp(t, test.expectedErr, err.Error())
 			}
 		})
 	}