diff --git a/frontend/packages/console-app/src/actions/hooks/useCommonActions.ts b/frontend/packages/console-app/src/actions/hooks/useCommonActions.ts index bdc56a606a6..ce0846aab00 100644 --- a/frontend/packages/console-app/src/actions/hooks/useCommonActions.ts +++ b/frontend/packages/console-app/src/actions/hooks/useCommonActions.ts @@ -6,10 +6,10 @@ import { useDeepCompareMemoize } from '@console/dynamic-plugin-sdk/src/utils/k8s import { annotationsModalLauncher, LazyDeleteModalOverlay, + LazyTolerationsModalOverlay, labelsModalLauncher, podSelectorModal, taintsModal, - tolerationsModal, } from '@console/internal/components/modals'; import { useConfigureCountModal } from '@console/internal/components/modals/configure-count-modal'; import { asAccessReview } from '@console/internal/components/utils/rbac'; @@ -142,7 +142,7 @@ export const useCommonActions = ( id: 'edit-toleration', label: t('console-app~Edit tolerations'), cta: () => - tolerationsModal({ + launchModal(LazyTolerationsModalOverlay, { resourceKind: kind, resource, modalClassName: 'modal-lg', @@ -172,7 +172,7 @@ export const useCommonActions = ( }), }), // Excluding stable modal launcher functions (labelsModalLauncher, annotationsModalLauncher, podSelectorModal, - // tolerationsModal, taintsModal, launchCountModal) to prevent unnecessary re-renders + // taintsModal, launchCountModal) to prevent unnecessary re-renders // TODO: remove once all Modals have been updated to useOverlay // eslint-disable-next-line react-hooks/exhaustive-deps [kind, resource, t, message, actualEditPath, launchModal], diff --git a/frontend/public/components/cluster-settings/cluster-settings.tsx b/frontend/public/components/cluster-settings/cluster-settings.tsx index 1f776252522..fa3a540cd49 100644 --- a/frontend/public/components/cluster-settings/cluster-settings.tsx +++ b/frontend/public/components/cluster-settings/cluster-settings.tsx @@ -1,5 +1,6 @@ /* eslint-disable @typescript-eslint/no-use-before-define */ import type { FC, ReactNode } from 'react'; +import { useEffect } from 'react'; import * as _ from 'lodash'; import { css } from '@patternfly/react-styles'; import * as semver from 'semver'; @@ -37,7 +38,11 @@ import PaneBody from '@console/shared/src/components/layout/PaneBody'; import PaneBodyGroup from '@console/shared/src/components/layout/PaneBodyGroup'; import { ClusterOperatorPage } from './cluster-operator'; -import { clusterChannelModal, clusterMoreUpdatesModal, clusterUpdateModal } from '../modals'; +import { + LazyClusterChannelModalOverlay, + LazyClusterMoreUpdatesModalOverlay, + LazyClusterUpdateModalOverlay, +} from '../modals'; import { GlobalConfigPage } from './global-config'; import { ClusterAutoscalerModel, @@ -167,6 +172,7 @@ const calculatePercentage = (numerator: number, denominator: number): number => export const CurrentChannel: FC = ({ cv, canUpgrade }) => { const { t } = useTranslation(); + const launchModal = useOverlay(); const label = cv.spec.channel || t('public~Not configured'); return canUpgrade ? (