Update DNSType in Infra CR's Platform Status

Currently, the DNSType is immutable once set. ARO needs to enable
this capability of starting in-cluster DNS on Day-2. That would
require changing the value of DNSType on Day-2 to `ClusterHosted`.
Similarly, they would also like the option to disable this feature
on Day-2 as well.

Author: sadasu

config/v1/tests/infrastructures.config.openshift.io/AWSClusterHostedDNS.yaml

@@ -140,7 +140,7 @@ tests:
               cloudLoadBalancerConfig:
                 dnsType: PlatformDefault
             type: AWS
-      expectedStatusError: "status.platformStatus.aws.cloudLoadBalancerConfig.dnsType: Invalid value: \"string\": dnsType is immutable"
+      expectedStatusError: "status.platformStatus.aws: Invalid value: \"object\": cloudLoadBalancerConfig.dnsType is immutable once set"
     - name: Should not accept non-IP address values for Load Balancer IPs
       initial: |
         apiVersion: config.openshift.io/v1

config/v1/tests/infrastructures.config.openshift.io/AWSClusterHostedDNSInstall.yaml

@@ -140,7 +140,7 @@ tests:
               cloudLoadBalancerConfig:
                 dnsType: PlatformDefault
             type: AWS
-      expectedStatusError: "status.platformStatus.aws.cloudLoadBalancerConfig.dnsType: Invalid value: \"string\": dnsType is immutable"
+      expectedStatusError: "status.platformStatus.aws: Invalid value: \"object\": cloudLoadBalancerConfig.dnsType is immutable once set"
     - name: Should not accept non-IP address values for Load Balancer IPs
       initial: |
         apiVersion: config.openshift.io/v1

config/v1/tests/infrastructures.config.openshift.io/AzureClusterHostedDNSInstall.yaml

@@ -104,7 +104,7 @@ tests:
                 dnsType: ClusterHosted
               ipFamily: IPv4
             type: Azure
-    - name: Should not allow changing the immutable dnsType field
+    - name: Should allow changing dnsType field for Azure platform
       initial: |
         apiVersion: config.openshift.io/v1
         kind: Infrastructure
@@ -140,7 +140,24 @@ tests:
               cloudLoadBalancerConfig:
                 dnsType: PlatformDefault
             type: Azure
-      expectedStatusError: "status.platformStatus.azure.cloudLoadBalancerConfig.dnsType: Invalid value: \"string\": dnsType is immutable"
+      expected: |
+        apiVersion: config.openshift.io/v1
+        kind: Infrastructure
+        spec:
+          platformSpec:
+            type: Azure
+            azure: {}
+        status:
+          controlPlaneTopology: HighlyAvailable
+          cpuPartitioning: None
+          infrastructureTopology: HighlyAvailable
+          platform: Azure
+          platformStatus:
+            azure:
+              cloudLoadBalancerConfig:
+                dnsType: PlatformDefault
+              ipFamily: IPv4
+            type: Azure
     - name: Should not accept non-IP address values for Load Balancer IPs
       initial: |
         apiVersion: config.openshift.io/v1

config/v1/tests/infrastructures.config.openshift.io/GCPClusterHostedDNS.yaml

@@ -138,7 +138,7 @@ tests:
               cloudLoadBalancerConfig:
                 dnsType: PlatformDefault
             type: GCP
-      expectedStatusError: "status.platformStatus.gcp.cloudLoadBalancerConfig.dnsType: Invalid value: \"string\": dnsType is immutable"
+      expectedStatusError: "status.platformStatus.gcp: Invalid value: \"object\": cloudLoadBalancerConfig.dnsType is immutable once set"
     - name: Should not accept non-IP address values for Load Balancer IPs
       initial: |
         apiVersion: config.openshift.io/v1

config/v1/tests/infrastructures.config.openshift.io/GCPClusterHostedDNSInstall.yaml

@@ -138,7 +138,7 @@ tests:
               cloudLoadBalancerConfig:
                 dnsType: PlatformDefault
             type: GCP
-      expectedStatusError: "status.platformStatus.gcp.cloudLoadBalancerConfig.dnsType: Invalid value: \"string\": dnsType is immutable"
+      expectedStatusError: "status.platformStatus.gcp: Invalid value: \"object\": cloudLoadBalancerConfig.dnsType is immutable once set"
     - name: Should not accept non-IP address values for Load Balancer IPs
       initial: |
         apiVersion: config.openshift.io/v1

config/v1/types_infrastructure.go

@@ -559,6 +559,7 @@ type AWSPlatformStatus struct {
 	//
 	// +default={"dnsType": "PlatformDefault"}
 	// +kubebuilder:default={"dnsType": "PlatformDefault"}
+	// +kubebuilder:validation:XValidation:rule=oldSelf.cloudLoadBalancerConfig.dnsType == '' || self.cloudLoadBalancerConfig.dnsType == oldSelf.cloudLoadBalancerConfig.dnsType,message="cloudLoadBalancerConfig.dnsType is immutable once set"
 	// +openshift:enable:FeatureGate=AWSClusterHostedDNSInstall
 	// +optional
 	// +nullable
@@ -640,6 +641,7 @@ type AzurePlatformStatus struct {
 	// When using the ClusterHosted DNS type, Load Balancer IP addresses
 	// must be provided for the API and internal API load balancers as well as the
 	// ingress load balancer.
+	// For Azure platform, cloudLoadBalancerConfig.dnsType can be updated after it has been set.
 	//
 	// +default={"dnsType": "PlatformDefault"}
 	// +kubebuilder:default={"dnsType": "PlatformDefault"}
@@ -787,6 +789,7 @@ type GCPPlatformStatus struct {
 	//
 	// +default={"dnsType": "PlatformDefault"}
 	// +kubebuilder:default={"dnsType": "PlatformDefault"}
+	// +kubebuilder:validation:XValidation:rule="oldSelf.cloudLoadBalancerConfig.dnsType == '' || self.cloudLoadBalancerConfig.dnsType == oldSelf.cloudLoadBalancerConfig.dnsType",message="cloudLoadBalancerConfig.dnsType is immutable once set"
 	// +openshift:enable:FeatureGate=GCPClusterHostedDNSInstall
 	// +optional
 	// +nullable
@@ -877,15 +880,15 @@ type CloudLoadBalancerConfig struct {
 	// It can be set to `ClusterHosted` to bypass the configuration of the cloud default DNS. In this mode,
 	// the cluster needs to provide a self-hosted DNS solution for the cluster's installation to succeed.
 	// The cluster's use of the cloud's Load Balancers is unaffected by this setting.
-	// The value is immutable after it has been set at install time.
+	// The value is immutable after it has been set at install time for AWS and GCP platforms.
+	// For Azure platform, this value can be updated after it has been set.
 	// Currently, there is no way for the customer to add additional DNS entries into the cluster hosted DNS.
 	// Enabling this functionality allows the user to start their own DNS solution outside the cluster after
 	// installation is complete. The customer would be responsible for configuring this custom DNS solution,
 	// and it can be run in addition to the in-cluster DNS solution.
 	// +default="PlatformDefault"
 	// +kubebuilder:default:="PlatformDefault"
 	// +kubebuilder:validation:Enum="ClusterHosted";"PlatformDefault"
-	// +kubebuilder:validation:XValidation:rule="oldSelf == '' || self == oldSelf",message="dnsType is immutable"
 	// +optional
 	// +unionDiscriminator
 	DNSType DNSType `json:"dnsType,omitempty"`

config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_infrastructures-CustomNoUpgrade.crd.yaml

@@ -1336,7 +1336,8 @@ spec:
                               It can be set to `ClusterHosted` to bypass the configuration of the cloud default DNS. In this mode,
                               the cluster needs to provide a self-hosted DNS solution for the cluster's installation to succeed.
                               The cluster's use of the cloud's Load Balancers is unaffected by this setting.
-                              The value is immutable after it has been set at install time.
+                              The value is immutable after it has been set at install time for AWS and GCP platforms.
+                              For Azure platform, this value can be updated after it has been set.
                               Currently, there is no way for the customer to add additional DNS entries into the cluster hosted DNS.
                               Enabling this functionality allows the user to start their own DNS solution outside the cluster after
                               installation is complete. The customer would be responsible for configuring this custom DNS solution,
@@ -1345,15 +1346,16 @@ spec:
                             - ClusterHosted
                             - PlatformDefault
                             type: string
-                            x-kubernetes-validations:
-                            - message: dnsType is immutable
-                              rule: oldSelf == '' || self == oldSelf
                         type: object
                         x-kubernetes-validations:
                         - message: clusterHosted is permitted only when dnsType is
                             ClusterHosted
                           rule: 'has(self.dnsType) && self.dnsType != ''ClusterHosted''
                             ? !has(self.clusterHosted) : true'
+                        - message: cloudLoadBalancerConfig.dnsType is immutable once
+                            set
+                          rule: oldSelf.cloudLoadBalancerConfig.dnsType == '' || self.cloudLoadBalancerConfig.dnsType
+                            == oldSelf.cloudLoadBalancerConfig.dnsType
                       ipFamily:
                         default: IPv4
                         description: |-
@@ -1466,6 +1468,7 @@ spec:
                           When using the ClusterHosted DNS type, Load Balancer IP addresses
                           must be provided for the API and internal API load balancers as well as the
                           ingress load balancer.
+                          For Azure platform, cloudLoadBalancerConfig.dnsType can be updated after it has been set.
                         properties:
                           clusterHosted:
                             description: |-
@@ -1541,7 +1544,8 @@ spec:
                               It can be set to `ClusterHosted` to bypass the configuration of the cloud default DNS. In this mode,
                               the cluster needs to provide a self-hosted DNS solution for the cluster's installation to succeed.
                               The cluster's use of the cloud's Load Balancers is unaffected by this setting.
-                              The value is immutable after it has been set at install time.
+                              The value is immutable after it has been set at install time for AWS and GCP platforms.
+                              For Azure platform, this value can be updated after it has been set.
                               Currently, there is no way for the customer to add additional DNS entries into the cluster hosted DNS.
                               Enabling this functionality allows the user to start their own DNS solution outside the cluster after
                               installation is complete. The customer would be responsible for configuring this custom DNS solution,
@@ -1550,9 +1554,6 @@ spec:
                             - ClusterHosted
                             - PlatformDefault
                             type: string
-                            x-kubernetes-validations:
-                            - message: dnsType is immutable
-                              rule: oldSelf == '' || self == oldSelf
                         type: object
                         x-kubernetes-validations:
                         - message: clusterHosted is permitted only when dnsType is
@@ -1918,7 +1919,8 @@ spec:
                               It can be set to `ClusterHosted` to bypass the configuration of the cloud default DNS. In this mode,
                               the cluster needs to provide a self-hosted DNS solution for the cluster's installation to succeed.
                               The cluster's use of the cloud's Load Balancers is unaffected by this setting.
-                              The value is immutable after it has been set at install time.
+                              The value is immutable after it has been set at install time for AWS and GCP platforms.
+                              For Azure platform, this value can be updated after it has been set.
                               Currently, there is no way for the customer to add additional DNS entries into the cluster hosted DNS.
                               Enabling this functionality allows the user to start their own DNS solution outside the cluster after
                               installation is complete. The customer would be responsible for configuring this custom DNS solution,
@@ -1927,15 +1929,16 @@ spec:
                             - ClusterHosted
                             - PlatformDefault
                             type: string
-                            x-kubernetes-validations:
-                            - message: dnsType is immutable
-                              rule: oldSelf == '' || self == oldSelf
                         type: object
                         x-kubernetes-validations:
                         - message: clusterHosted is permitted only when dnsType is
                             ClusterHosted
                           rule: 'has(self.dnsType) && self.dnsType != ''ClusterHosted''
                             ? !has(self.clusterHosted) : true'
+                        - message: cloudLoadBalancerConfig.dnsType is immutable once
+                            set
+                          rule: oldSelf.cloudLoadBalancerConfig.dnsType == '' || self.cloudLoadBalancerConfig.dnsType
+                            == oldSelf.cloudLoadBalancerConfig.dnsType
                       projectID:
                         description: resourceGroupName is the Project ID for new GCP
                           resources created for the cluster.

config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_infrastructures-Default.crd.yaml

@@ -1580,7 +1580,8 @@ spec:
                               It can be set to `ClusterHosted` to bypass the configuration of the cloud default DNS. In this mode,
                               the cluster needs to provide a self-hosted DNS solution for the cluster's installation to succeed.
                               The cluster's use of the cloud's Load Balancers is unaffected by this setting.
-                              The value is immutable after it has been set at install time.
+                              The value is immutable after it has been set at install time for AWS and GCP platforms.
+                              For Azure platform, this value can be updated after it has been set.
                               Currently, there is no way for the customer to add additional DNS entries into the cluster hosted DNS.
                               Enabling this functionality allows the user to start their own DNS solution outside the cluster after
                               installation is complete. The customer would be responsible for configuring this custom DNS solution,
@@ -1589,15 +1590,16 @@ spec:
                             - ClusterHosted
                             - PlatformDefault
                             type: string
-                            x-kubernetes-validations:
-                            - message: dnsType is immutable
-                              rule: oldSelf == '' || self == oldSelf
                         type: object
                         x-kubernetes-validations:
                         - message: clusterHosted is permitted only when dnsType is
                             ClusterHosted
                           rule: 'has(self.dnsType) && self.dnsType != ''ClusterHosted''
                             ? !has(self.clusterHosted) : true'
+                        - message: cloudLoadBalancerConfig.dnsType is immutable once
+                            set
+                          rule: oldSelf.cloudLoadBalancerConfig.dnsType == '' || self.cloudLoadBalancerConfig.dnsType
+                            == oldSelf.cloudLoadBalancerConfig.dnsType
                       projectID:
                         description: resourceGroupName is the Project ID for new GCP
                           resources created for the cluster.