Skip to content

Conversation

@cybertron
Copy link
Contributor

Add an EXTERNAL_LOADBALANCER option to the config settings that configures the external loadbalancer and tells the cluster to use it instead of the internal one.

@openshift-ci openshift-ci bot requested review from elfosardo and mkowalski December 4, 2025 20:49
@openshift-ci
Copy link

openshift-ci bot commented Dec 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign derekhiggins for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Dec 4, 2025

@cybertron: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images f43725b link true /test images
ci/prow/e2e-agent-compact-ipv4 f43725b link true /test e2e-agent-compact-ipv4
ci/prow/e2e-agent-5control-ipv4 f43725b link false /test e2e-agent-5control-ipv4
ci/prow/e2e-agent-compact-ipv4-iso-no-registry f43725b link false /test e2e-agent-compact-ipv4-iso-no-registry
ci/prow/e2e-agent-4control-ipv4 f43725b link false /test e2e-agent-4control-ipv4
ci/prow/e2e-agent-ha-dualstack f43725b link false /test e2e-agent-ha-dualstack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Comment on lines +32 to +34
if [ -n "$EXTERNAL_LOADBALANCER" ]; then
./external_loadbalancer.sh &
fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One detail I would like to see is a failure of the script if you set EXTERNAL_LOADBALANCER but do not set ENABLE_BOOTSTRAP_STATIC_IP=true. Otherwise we will proceed with openshift-install which will fail and you will end up in a debugging nightmare

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants