WIP: Add REGISTRY_INSECURE option for mirror registry w/o certificate validation #1821
+108
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…validation This commit adds a new REGISTRY_INSECURE environment variable that allows the mirrored registry backend to operate without requiring certificate validation. When enabled, this simplifies testing and development workflows by avoiding certificate management overhead. Changes: - Add REGISTRY_INSECURE variable documentation in config_example.sh - Skip adding registry certificate to system trust store when insecure mode is enabled (utils.sh) - Skip copying ca-bundle.crt to mirror path when insecure mode is enabled (agent/05_agent_configure.sh) - Skip loading certificate files in Ansible when insecure mode is enabled (agent/roles/manifests/tasks/main.yml) - Add conditional --tls-verify=false to podman login (02_configure_host.sh) - Add conditional --insecure flag to oc adm release extract commands (ocp_install_env.sh, utils.sh) - Add conditional --insecure flag to oc adm release info commands (release_info.sh) - Add --ignore-release-signature flag to oc-mirror commands (oc_mirror.sh) - Implement workaround for oc-mirror v2 TLS verification issue by temporarily adding cert to system trust during oc-mirror operation (oc_mirror.sh) - Omit additionalTrustBundle from install-config when insecure mode is enabled (install-config_yaml.j2, install-config_baremetal_yaml.j2, install-config_vsphere_yaml.j2) - Add insecure=true to registry mirror configurations in registries.conf (registries_conf.j2, ztp.yml) - Add registry_insecure variable to Ansible vars (vars/main.yml) Implementation details: - Registry backend still generates and uses self-signed HTTPS certificates - Clients skip certificate verification when REGISTRY_INSECURE=true - The certificate is temporarily trusted only during oc-mirror operations (workaround for oc-mirror v2 bug) then immediately removed - Installation proceeds with insecure registry configuration in registries.conf Default: REGISTRY_INSECURE is false (secure mode with certificate validation)
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@bfournie: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a POC for using a insecure local registry.
This commit adds a new REGISTRY_INSECURE environment variable that allows the mirrored registry backend to operate without requiring certificate validation. When enabled, this simplifies testing and development workflows by avoiding certificate management overhead.
Changes:
Implementation details:
Default: REGISTRY_INSECURE is false (secure mode with certificate validation)