fix: eliminate redundant workflow DB queries and admin list N+1 (v0.37.14)

tasks.py:
- send_rejection/approval/submission/withdrawal_notification: read
  hide_approval_history from already-resolved local workflow var
  instead of calling _get_hide_approval_history(submission) which
  issued a duplicate workflows.first() DB query
- send_submission_form_field_notifications: resolve workflow once
  before the notification loop; pre-compute hide_approval_history
- send_workflow_definition_notifications: same pattern, resolve
  workflow and hide_approval_history once before the loop

admin.py:
- WorkflowNotificationAdmin: add list_select_related =
  (workflow__form_definition,) to eliminate the 2-query N+1 on
  the list page caused by workflow_form() traversing the FK chain

Bump 0.37.13 to 0.37.14

Author: matteius

CHANGELOG.md

@@ -7,6 +7,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.37.14] - 2026-03-27
+
+### Fixed
+- **Double `workflow` DB query in 4 notification tasks** — `send_rejection_notification`, `send_approval_notification`, `send_submission_notification`, and `send_withdrawal_notification` each already resolve `workflow = getattr(submission.form_definition, "workflow", None)` for the toggle check. The subsequent `_get_hide_approval_history(submission)` call was redundantly calling `workflows.first()` a second time. The flag is now read directly from the local `workflow` variable with `bool(getattr(workflow, "hide_approval_history", False))`.
+- **Extra `workflow` fetch in `send_submission_form_field_notifications` and `send_workflow_definition_notifications`** — neither task had a local `workflow` variable, so every iteration of their notification loop called `_get_hide_approval_history(submission)` → `workflows.first()`. Both tasks now resolve `workflow` once at the top and pre-compute `hide_approval_history` before the loop; the per-notif context dict reads the pre-computed value.
+- **`WorkflowNotificationAdmin` list page N+1** — `workflow_form()` accessed `obj.workflow.form_definition.name` without any join, causing 2 extra queries per row. Added `list_select_related = ("workflow__form_definition",)` so the list page is served in a single query.
+
 ## [0.37.13] - 2026-03-27
 
 ### Fixed

django_forms_workflows/admin.py

@@ -1536,6 +1536,7 @@ class WorkflowNotificationAdmin(admin.ModelAdmin):
         "subject_template_truncated",
     )
     list_filter = ("notification_type", "workflow__form_definition")
+    list_select_related = ("workflow__form_definition",)
     search_fields = (
         "workflow__form_definition__name",
         "email_field",

django_forms_workflows/tasks.py

@@ -329,7 +329,9 @@ def send_rejection_notification(submission_id: int) -> None:
         "submission": submission,
         "task": task,
         "submission_url": submission_url,
-        "hide_approval_history": _get_hide_approval_history(submission),
+        "hide_approval_history": bool(
+            getattr(workflow, "hide_approval_history", False)
+        ),
     }
     subject = (
         f"Submission Rejected: {submission.form_definition.name} (ID {submission.id})"
@@ -374,7 +376,9 @@ def send_approval_notification(submission_id: int) -> None:
     context = {
         "submission": submission,
         "submission_url": submission_url,
-        "hide_approval_history": _get_hide_approval_history(submission),
+        "hide_approval_history": bool(
+            getattr(workflow, "hide_approval_history", False)
+        ),
     }
     subject = (
         f"Submission Approved: {submission.form_definition.name} (ID {submission.id})"
@@ -417,7 +421,9 @@ def send_submission_notification(submission_id: int) -> None:
     context = {
         "submission": submission,
         "submission_url": submission_url,
-        "hide_approval_history": _get_hide_approval_history(submission),
+        "hide_approval_history": bool(
+            getattr(workflow, "hide_approval_history", False)
+        ),
     }
     subject = (
         f"Submission Received: {submission.form_definition.name} (ID {submission.id})"
@@ -955,6 +961,9 @@ def send_submission_form_field_notifications(
     form_data = submission.form_data or {}
     form_name = submission.form_definition.name
     submission_url, _ = _build_form_field_notification_context(submission)
+    # Resolve once — reused for hide_approval_history below.
+    workflow = getattr(submission.form_definition, "workflow", None)
+    hide_approval_history = bool(getattr(workflow, "hide_approval_history", False))
 
     notifications = StageFormFieldNotification.objects.filter(
         stage__workflow__form_definition=submission.form_definition,
@@ -997,7 +1006,7 @@ def send_submission_form_field_notifications(
         context = {
             "submission": submission,
             "submission_url": submission_url,
-            "hide_approval_history": _get_hide_approval_history(submission),
+            "hide_approval_history": hide_approval_history,
         }
         _send_html_email(
             subject,
@@ -1029,7 +1038,9 @@ def send_withdrawal_notification(submission_id: int) -> None:
     context = {
         "submission": submission,
         "submission_url": submission_url,
-        "hide_approval_history": _get_hide_approval_history(submission),
+        "hide_approval_history": bool(
+            getattr(workflow, "hide_approval_history", False)
+        ),
     }
     subject = (
         f"Submission Withdrawn: {submission.form_definition.name} (ID {submission.id})"
@@ -1094,6 +1105,9 @@ def send_workflow_definition_notifications(
     form_data = submission.form_data or {}
     form_name = submission.form_definition.name
     submission_url, _ = _build_form_field_notification_context(submission)
+    # Resolve once — reused for hide_approval_history in every email context below.
+    workflow = getattr(submission.form_definition, "workflow", None)
+    hide_approval_history = bool(getattr(workflow, "hide_approval_history", False))
 
     default_subjects = {
         "submission_received": f"Submission Received: {form_name} (ID {submission.id})",
@@ -1150,7 +1164,7 @@ def send_workflow_definition_notifications(
         context = {
             "submission": submission,
             "submission_url": submission_url,
-            "hide_approval_history": _get_hide_approval_history(submission),
+            "hide_approval_history": hide_approval_history,
         }
 
         # Send one email per recipient so each message is independent

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "django-forms-workflows"
-version = "0.37.13"
+version = "0.37.14"
 description = "Enterprise-grade, database-driven form builder with approval workflows and external data integration"
 license = "LGPL-3.0-only"
 readme = "README.md"