Draft Rep 0158: OpenUSD interoperability#29
Open
adamdbrw wants to merge 111 commits into
Open
Conversation
Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Corrections to 1.1. and 1.2 Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Updated mass = 0 issue and introduced some detail Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Expanded on Inertia representation and mass Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Mateusz Żak <mateusz.zak@robotec.ai> Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Developed sub-criteria with more rigor Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Mateusz Żak <mateusz.zak@robotec.ai> Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Mateusz Żak <mateusz.zak@robotec.ai> Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Mateusz Żak <mateusz.zak@robotec.ai> Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Mateusz Żak <mateusz.zak@robotec.ai> Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Corrections, removed the version recommendation Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Co-authored-by: Franco Cipollone <franco.c@ekumenlabs.com> Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
- removed dictionary entry - removed empty def for frame override Co-authored-by Mateusz Żak <mateusz.zak@robotec.ai> Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Co-authored-by: Mateusz Żak <mateusz.zak@robotec.ai> Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Co-authored-by: Mateusz Żak <mateusz.zak@robotec.ai> Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
- Add a Layer Encoding rule: ascii for light, crate for heavy - Update the extenctions to canonical Co-authored-by: Renato Gasoto <rgasoto@nvidia.com> Signed-off-by: Mateusz Żak <mateusz.zak@robotec.ai> Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
State directly that: - assets must not duplicate the same ROS interface in another form - persisted runtime artifacts go in the proprietary layer Co-authored-by: Renato Gasoto <rgasoto@nvidia.com> Signed-off-by: Mateusz Żak <mateusz.zak@robotec.ai> Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Mateusz Żak <mateusz.zak@robotec.ai> Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
* Newton schemas are actually generatedSchema.usda, which is not valid input to `usdGenSchema` Signed-off-by: Mateusz Żak <mateusz.zak@robotec.ai> Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Co-authored-by: Mateusz Żak <mateusz.zak@robotec.ai> Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Michał Pełka <michal.pelka@robotec.ai> Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
- Move schema.usda up out of schema/ subdirs to follow OpenUSD convention (cf. usdLux) - Rename rigid_body_controller dir to rigid_body_twist_controller for consistency - Drop libraryPrefix (defaults to capitalized libraryName, gives PascalCase C++ class names) - Update README schema-path references accordingly Signed-off-by: Mateusz Żak <mateusz.zak@robotec.ai> Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
* this is to maintain per-controller libraries and avoid duplications in generated C++ identifiers (UsdRosControlDiffDriveRosControlDiffDriveAPI). Signed-off-by: Mateusz Żak <mateusz.zak@robotec.ai> Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Mateusz Żak <mateusz.zak@robotec.ai> Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Co-authored-by Mateusz Zak <mateusz.zak@robotec.ai> Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Wording polish and update of the chapter number Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Assorted improvements Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
- Renaming according to rep-0001 and proper catalogue structure for merge - Removed extensions and core schemas - these are submitted to ros-simulation/openusd-schemas instead. Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
adamdbrw
force-pushed
the
rep-0158-openusd-interoperability
branch
from
015d143 to
159ca5a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new REP for OpenUSD interoperability within ROS simulation ecosystem. The chief goal is to make simulation assets that work out of the box for all of us across simulators.
The REP is accompanied by https://github.com/ros-simulation/openusd-schemas repository, which hosts the implementation.
Essential implementation PRs:
Following the merge, I will start a discussion thread on Discord.