bugfix: use of lua-resty-core's ngx.re API in init_by_lua* might lead to memory issues during nginx HUP reload when no lua_shared_dict directives are used and the regex cache is enabled.

Author: agentzh

src/ngx_http_lua_regex.c

@@ -2199,6 +2199,8 @@ ngx_http_lua_ffi_compile_regex(const unsigned char *pat, size_t pat_len,
         goto error;
     }
 
+    pool->log = (ngx_log_t *) &ngx_cycle->new_log;
+
     re = ngx_palloc(pool, sizeof(ngx_http_lua_regex_t));
     if (re == NULL) {
         ngx_destroy_pool(pool);

t/124-init-worker.t

@@ -768,8 +768,9 @@ ok
     #lua_shared_dict dummy 500k;
 
     init_by_lua_block {
-        -- require "resty.core.regex"
-        -- assert(ngx.re.match("hello, world", [[hello, \w+]], "joi"))
+        require "resty.core.regex"
+        assert(ngx.re.match("hello, world", [[hello, \w+]], "joi"))
+        assert(ngx.re.match("hi, world", [[hi, \w+]], "ji"))
     }
 
 --- config
@@ -801,8 +802,9 @@ start privileged agent process
     lua_shared_dict dummy 500k;
 
     init_by_lua_block {
-        -- require "resty.core.regex"
-        -- assert(ngx.re.match("hello, world", [[hello, \w+]], "joi"))
+        require "resty.core.regex"
+        assert(ngx.re.match("hello, world", [[hello, \w+]], "joi"))
+        assert(ngx.re.match("hi, world", [[hi, \w+]], "ji"))
     }
 
 --- config
@@ -835,8 +837,9 @@ start privileged agent process
 
     init_by_lua_block {
         assert(require "ngx.process".enable_privileged_agent())
-        -- require "resty.core.regex"
-        -- assert(ngx.re.match("hello, world", [[hello, \w+]], "joi"))
+        require "resty.core.regex"
+        assert(ngx.re.match("hello, world", [[hello, \w+]], "joi"))
+        assert(ngx.re.match("hi, world", [[hi, \w+]], "ji"))
     }
 
 --- config
@@ -870,8 +873,9 @@ qr/start privileged agent process \d+/
 
     init_by_lua_block {
         assert(require "ngx.process".enable_privileged_agent())
-        -- require "resty.core.regex"
-        -- assert(ngx.re.match("hello, world", [[hello, \w+]], "joi"))
+        require "resty.core.regex"
+        assert(ngx.re.match("hello, world", [[hello, \w+]], "joi"))
+        assert(ngx.re.match("hi, world", [[hi, \w+]], "ji"))
     }
 
     init_worker_by_lua_block {
@@ -909,8 +913,9 @@ qr/lua close the global Lua VM ([0-9A-F]+)$/,
     proxy_cache_path /tmp/cache levels=1:2 keys_zone=cache:1m;
 
     init_by_lua_block {
-        -- require "resty.core.regex"
-        -- assert(ngx.re.match("hello, world", [[hello, \w+]], "joi"))
+        require "resty.core.regex"
+        assert(ngx.re.match("hello, world", [[hello, \w+]], "joi"))
+        assert(ngx.re.match("hi, world", [[hi, \w+]], "ji"))
     }
 
     init_worker_by_lua_block {