fix shortcuts and title label

Author: mikebarkmin

packages/learningmap/src/KeyboardShortcuts.tsx

@@ -33,6 +33,9 @@ export const KeyboardShortcuts = ({ jsonStore = "https://json.openpatch.org" }:
   const showGrid = useEditorStore(state => state.showGrid);
   const setShowGrid = useEditorStore(state => state.setShowGrid);
   const deleteNode = useEditorStore(state => state.deleteNode);
+  const drawerOpen = useEditorStore(state => state.drawerOpen);
+  const edgeDrawerOpen = useEditorStore(state => state.edgeDrawerOpen);
+  const settingsDrawerOpen = useEditorStore(state => state.settingsDrawerOpen);
 
   const language = settings?.language || "en";
   const t = getTranslations(language);
@@ -148,6 +151,9 @@ export const KeyboardShortcuts = ({ jsonStore = "https://json.openpatch.org" }:
 
   useEffect(() => {
     const handleKeyDown = (e: KeyboardEvent) => {
+      if (drawerOpen || edgeDrawerOpen || settingsDrawerOpen) {
+        return; // Ignore shortcuts when any drawer is open
+      }
       if (e.ctrlKey || e.metaKey) {
         if (e.key === '1') {
           e.preventDefault();
@@ -227,7 +233,7 @@ export const KeyboardShortcuts = ({ jsonStore = "https://json.openpatch.org" }:
     };
   }, [onAddNode, onDeleteSelected, onSave, undo, redo, helpOpen, setHelpOpen, onTogglePreview, onToggleDebug,
     onZoomIn, onZoomOut, onResetZoom, onFitView, onZoomToSelection, onToggleGrid,
-    onResetMap, onCut, onCopy, onPaste, onSelectAll]);
+    onResetMap, onCut, onCopy, onPaste, onSelectAll, drawerOpen, edgeDrawerOpen, settingsDrawerOpen]);
 
   return null;
 };

packages/learningmap/src/SettingsDrawer.tsx

@@ -16,14 +16,14 @@ export const SettingsDrawer: React.FC<SettingsDrawerProps> = ({
   // Get state from store
   const isOpen = useEditorStore(state => state.settingsDrawerOpen);
   const settings = useEditorStore(state => state.settings);
-  
+
   // Get actions from store
   const setSettingsDrawerOpen = useEditorStore(state => state.setSettingsDrawerOpen);
   const setSettings = useEditorStore(state => state.setSettings);
-  
+
   const language = settings?.language || defaultLanguage;
   const t = getTranslations(language);
-  
+
   const [localSettings, setLocalSettings] = useState<Settings>(settings);
   const { getViewport } = useReactFlow();
 
@@ -32,7 +32,7 @@ export const SettingsDrawer: React.FC<SettingsDrawerProps> = ({
   }, [settings]);
 
   const onClose = () => setSettingsDrawerOpen(false);
-  
+
   const onUpdate = (s: Settings) => {
     setSettings(s);
   };
@@ -74,7 +74,7 @@ export const SettingsDrawer: React.FC<SettingsDrawerProps> = ({
               type="text"
               value={localSettings?.title || ""}
               onChange={(e) => setLocalSettings(settings => ({ ...settings, title: e.target.value }))}
-              placeholder={t.placeholderNodeLabel}
+              placeholder={t.placeholderTitleLabel}
             />
           </div>
           <div className="form-group">
@@ -94,7 +94,7 @@ export const SettingsDrawer: React.FC<SettingsDrawerProps> = ({
               onChange={color => setLocalSettings(settings => ({ ...settings, background: { ...settings.background, color } }))}
             />
           </div>
-          
+
           <div className="form-group">
             <label>{t.initialViewport}</label>
             <div style={{ display: 'flex', gap: '8px', alignItems: 'center', marginTop: '8px' }}>

packages/learningmap/src/translations.ts

@@ -96,6 +96,7 @@ export interface Translations {
 
   // Placeholders
   placeholderNodeLabel: string;
+  placerholderTitleLabel: string; // only used in SettingsDrawer
   placeholderShortSummary: string;
   placeholderDetailedDescription: string;
   placeholderVideoURL: string;
@@ -295,6 +296,7 @@ const en: Translations = {
 
   // Placeholders
   placeholderNodeLabel: "Node label",
+  placerholderTitleLabel: "Lerningmap label", // only used in SettingsDrawer
   placeholderShortSummary: "Short summary",
   placeholderDetailedDescription: "Detailed description",
   placeholderVideoURL: "YouTube or video URL",
@@ -316,8 +318,10 @@ const en: Translations = {
   failedToLoadFile:
     "Failed to load the file. Please make sure it is a valid roadmap JSON file.",
   failedToExportSVG: "Failed to export SVG: ",
-  loadExternalWarning: "Loading an external learningmap will replace your existing content. You can back up your current learningmap first by using one of the options below.",
-  loadExternalBackupPrompt: "Would you like to back up your current learningmap before loading the external one?",
+  loadExternalWarning:
+    "Loading an external learningmap will replace your existing content. You can back up your current learningmap first by using one of the options below.",
+  loadExternalBackupPrompt:
+    "Would you like to back up your current learningmap before loading the external one?",
   emptyMapCannotBeShared: "An empty learningmap cannot be shared.",
   uploadFailed: "Upload failed. Please try again!",
   loadFailed: "Failed to load. Please check the URL.",
@@ -499,6 +503,7 @@ const de: Translations = {
 
   // Placeholders
   placeholderNodeLabel: "Knotenbezeichnung",
+  placerholderTitleLabel: "Lernkartenbezeichnung", // only used in SettingsDrawer
   placeholderShortSummary: "Kurze Zusammenfassung",
   placeholderDetailedDescription: "Detaillierte Beschreibung",
   placeholderVideoURL: "YouTube oder Video-URL",
@@ -521,10 +526,13 @@ const de: Translations = {
   failedToLoadFile:
     "Datei konnte nicht geladen werden. Bitte stellen Sie sicher, dass es sich um eine gültige Roadmap-JSON-Datei handelt.",
   failedToExportSVG: "SVG-Export fehlgeschlagen: ",
-  loadExternalWarning: "Das Laden einer externen Learningmap ersetzt Ihren aktuellen Inhalt. Sie können Ihre aktuelle Learningmap zuerst sichern, indem Sie eine der folgenden Optionen verwenden.",
-  loadExternalBackupPrompt: "Möchten Sie Ihre aktuelle Learningmap sichern, bevor Sie die externe laden?",
+  loadExternalWarning:
+    "Das Laden einer externen Learningmap ersetzt Ihren aktuellen Inhalt. Sie können Ihre aktuelle Learningmap zuerst sichern, indem Sie eine der folgenden Optionen verwenden.",
+  loadExternalBackupPrompt:
+    "Möchten Sie Ihre aktuelle Learningmap sichern, bevor Sie die externe laden?",
   emptyMapCannotBeShared: "Eine leere Learningmap kann nicht geteilt werden.",
-  uploadFailed: "Beim Upload ist was schief gelaufen. Bitte versuche es erneut!",
+  uploadFailed:
+    "Beim Upload ist was schief gelaufen. Bitte versuche es erneut!",
   loadFailed: "Beim Laden ist etwas schief gegangen. Bitte überprüfe die URL.",
 
   // Share dialog