8372950: Pem.pemEncoded should cache the Pattern #28661
Open
+5
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEM is using the String.replaceAll() method that creates a Pattern internally every time. This looks like a minor inefficiency and since it is caching Patterns for other cases, it should do the same here.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28661/head:pull/28661$ git checkout pull/28661Update a local copy of the PR:
$ git checkout pull/28661$ git pull https://git.openjdk.org/jdk.git pull/28661/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28661View PR using the GUI difftool:
$ git pr show -t 28661Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28661.diff
Using Webrev
Link to Webrev Comment