Skip to content

Conversation

@fguallini
Copy link
Member

@fguallini fguallini commented Dec 4, 2025

PEM is using the String.replaceAll() method that creates a Pattern internally every time. This looks like a minor inefficiency and since it is caching Patterns for other cases, it should do the same here.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8372950: Pem.pemEncoded should cache the Pattern (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28661/head:pull/28661
$ git checkout pull/28661

Update a local copy of the PR:
$ git checkout pull/28661
$ git pull https://git.openjdk.org/jdk.git pull/28661/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28661

View PR using the GUI difftool:
$ git pr show -t 28661

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28661.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 4, 2025

👋 Welcome back fguallini! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 4, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title JDK-8372950: Pem.pemEncoded should cache the Pattern 8372950: Pem.pemEncoded should cache the Pattern Dec 4, 2025
@openjdk openjdk bot added the security security-dev@openjdk.org label Dec 4, 2025
@openjdk
Copy link

openjdk bot commented Dec 4, 2025

@fguallini The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@fguallini fguallini marked this pull request as ready for review December 8, 2025 17:02
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 8, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 8, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfr Pull request is ready for review security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

1 participant