-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8372589: VM crashes on init when NonNMethodCodeHeapSize is set too small and UseTransparentHugePages is enabled #28658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…all and UseTransparentHugePages is enabled
|
👋 Welcome back dbriemann! A progress list of the required criteria for merging this PR into |
|
@dbriemann This change is no longer ready for integration - check the PR body for details. |
|
@dbriemann The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
TheRealMDoerr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This make sense. Please make sure to commit it when JDK27 is started in head and after a 2nd review.
/reviewers 2
|
@TheRealMDoerr |
|
Hi @chhagedorn since you had a look at the ticket, would you be willing to review this PR? Thanks. |
Aligning upwards instead of downwards not only solves the crash in large huge page scenarios but also ensures that the cache sizes are at least as big as they were set.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28658/head:pull/28658$ git checkout pull/28658Update a local copy of the PR:
$ git checkout pull/28658$ git pull https://git.openjdk.org/jdk.git pull/28658/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28658View PR using the GUI difftool:
$ git pr show -t 28658Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28658.diff
Using Webrev
Link to Webrev Comment