Skip to content

Commit 826a8f3

Browse files
committed
refactor: moves tags_count into LibraryItem
because anything that appears in a library may be tagged.
1 parent 181bb64 commit 826a8f3

3 files changed

Lines changed: 2 additions & 3 deletions

File tree

openedx/core/djangoapps/content_libraries/api/block_metadata.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,6 @@ class LibraryXBlockMetadata(PublishableItem):
2626
Class that represents the metadata about an XBlock in a content library.
2727
"""
2828
usage_key: LibraryUsageLocatorV2
29-
# TODO: move tags_count to LibraryItem as all objects under a library can be tagged.
30-
tags_count: int = 0
3129

3230
@classmethod
3331
def from_component(cls, library_key, component, associated_collections=None):

openedx/core/djangoapps/content_libraries/api/libraries.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -184,6 +184,7 @@ class LibraryItem:
184184
created: datetime
185185
modified: datetime
186186
display_name: str
187+
tags_count: int = 0
187188

188189

189190
@dataclass(frozen=True, kw_only=True)

openedx/core/djangoapps/content_libraries/rest_api/serializers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,7 @@ class PublishableItemSerializer(serializers.Serializer):
138138
"""
139139
id = serializers.SerializerMethodField()
140140
display_name = serializers.CharField()
141+
tags_count = serializers.IntegerField(read_only=True)
141142
last_published = serializers.DateTimeField(format=DATETIME_FORMAT, read_only=True)
142143
published_by = serializers.CharField(read_only=True)
143144
last_draft_created = serializers.DateTimeField(format=DATETIME_FORMAT, read_only=True)
@@ -149,7 +150,6 @@ class PublishableItemSerializer(serializers.Serializer):
149150
# When creating a new XBlock in a library, the slug becomes the ID part of
150151
# the definition key and usage key:
151152
slug = serializers.CharField(write_only=True)
152-
tags_count = serializers.IntegerField(read_only=True)
153153

154154
collections = CollectionMetadataSerializer(many=True, required=False)
155155
can_stand_alone = serializers.BooleanField(read_only=True)

0 commit comments

Comments
 (0)