fix: updating tests and fixing code

Author: rpenido

openedx_learning/apps/authoring/collections/api.py

@@ -234,15 +234,12 @@ def set_collections(
     removed_collections = set(
         r.collection for r in current_relations.exclude(collection__in=collection_qset)
     )
-    removed_collections = set(
-        r.collection for r in current_relations.exclude(collection__in=collection_qset)
-    )
     new_collections = set(collection_qset.exclude(
         id__in=current_relations.values_list('collection', flat=True)
     ))
     # Triggers a m2m_changed signal
     publishable_entity.collections.set(
-        objs=new_collections,
+        objs=collection_qset,
         through_defaults={"created_by_id": created_by},
     )
     # Update modified date via update to avoid triggering post_save signal for all collections, which can be very slow.

tests/openedx_learning/apps/authoring/collections/test_api.py

@@ -637,7 +637,6 @@ def test_set_collections(self):
         modified_time = datetime(2024, 8, 8, tzinfo=timezone.utc)
         with freeze_time(modified_time):
             api.set_collections(
-                self.learning_package.id,
                 self.draft_component.publishable_entity,
                 collection_qset=Collection.objects.filter(id__in=[
                     self.collection1.pk,
@@ -675,7 +674,6 @@ def test_set_collections(self):
         new_modified_time = datetime(2024, 8, 8, tzinfo=timezone.utc)
         with freeze_time(new_modified_time):
             api.set_collections(
-                self.learning_package.id,
                 self.draft_component.publishable_entity,
                 collection_qset=Collection.objects.filter(id__in=[
                     self.collection3.pk,
@@ -708,13 +706,20 @@ def test_set_collection_wrong_learning_package(self):
             key="ComponentTestCase-test-key-3",
             title="Components Test Case Learning Package-3",
         )
+        collection = api.create_collection(
+            learning_package_3.id,
+            key="MYCOL",
+            title="My Collection",
+            created_by=None,
+            description="Description of Collection",
+        )
+
 
         with self.assertRaises(ValidationError):
             api.set_collections(
-                learning_package_3.id,
                 self.draft_component.publishable_entity,
                 collection_qset=Collection.objects.filter(id__in=[
-                    self.collection1.pk,
+                    collection.pk,
                 ]),
                 created_by=self.user.id,
             )