Skip to content

Commit 03ed419

Browse files
committed
temp: pylint cleanup
1 parent 4fcf5c2 commit 03ed419

10 files changed

Lines changed: 42 additions & 79 deletions

File tree

openedx_learning/api/authoring.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,7 @@
99
"""
1010
# These wildcard imports are okay because these api modules declare __all__.
1111
# pylint: disable=wildcard-import
12-
from ..apps.authoring.applets.backup_restore.api import *
13-
from ..apps.authoring.applets.collections.api import *
14-
from ..apps.authoring.applets.components.api import *
15-
from ..apps.authoring.applets.contents.api import *
16-
from ..apps.authoring.applets.publishing.api import *
17-
from ..apps.authoring.applets.sections.api import *
18-
from ..apps.authoring.applets.subsections.api import *
19-
from ..apps.authoring.applets.units.api import *
12+
from ..apps.authoring.api import *
2013

2114
# This was renamed after the authoring API refactoring pushed this and other
2215
# app APIs into the openedx_learning.api.authoring module. Here I'm aliasing to

openedx_learning/apps/authoring/admin.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
"""
2+
This module aggregates all applet Django Admin modules.
3+
"""
4+
# pylint: disable=wildcard-import
5+
16
from .applets.backup_restore.admin import *
27
from .applets.collections.admin import *
38
from .applets.components.admin import *
@@ -6,7 +11,3 @@
611
from .applets.sections.admin import *
712
from .applets.subsections.admin import *
813
from .applets.units.admin import *
9-
10-
#from openedx_learning.lib import appletslib
11-
12-
#globals().update(appletslib.auto_import_admin())

openedx_learning/apps/authoring/api.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,11 @@
1+
"""
2+
This module aggregates all applet API modules.
3+
4+
Question: Should this replace openedx_learning.api.authoring?
5+
"""
6+
7+
# pylint: disable=wildcard-import
8+
19
from .applets.backup_restore.api import *
210
from .applets.collections.api import *
311
from .applets.components.api import *
@@ -6,7 +14,3 @@
614
from .applets.sections.api import *
715
from .applets.subsections.api import *
816
from .applets.units.api import *
9-
10-
#from openedx_learning.lib import appletslib
11-
12-
#globals().update(appletslib.auto_import_api())

openedx_learning/apps/authoring/applets/contents/models.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,12 @@
1616
from django.db import models
1717
from django.utils.module_loading import import_string
1818

19-
from openedx_learning.lib.fields import MultiCollationTextField, case_insensitive_char_field, hash_field, manual_date_time_field
19+
from openedx_learning.lib.fields import (
20+
MultiCollationTextField,
21+
case_insensitive_char_field,
22+
hash_field,
23+
manual_date_time_field,
24+
)
2025
from openedx_learning.lib.managers import WithRelationsManager
2126
from ..publishing.models import LearningPackage
2227

openedx_learning/apps/authoring/apps.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
1+
"""
2+
Docstring for openedx_learning.apps.authoring.apps
3+
"""
14
from django.apps import AppConfig
25

6+
37
class AuthoringConfig(AppConfig):
48
name = "openedx_learning.apps.authoring"
59
verbose_name = "Learning Core > Authoring"

openedx_learning/apps/authoring/management/commands/add_assets_to_component.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,7 @@
99

1010
from django.core.management.base import BaseCommand
1111

12-
from ....publishing.api import get_learning_package_by_key
13-
from ...api import create_next_component_version, get_component_by_key
12+
from ...api import create_next_component_version, get_component_by_key, get_learning_package_by_key
1413

1514

1615
class Command(BaseCommand):

openedx_learning/apps/authoring/models.py

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,12 @@
1+
"""
2+
This module aggregates all applet model modules.
3+
4+
I experimented with creating a utility to auto-detect applets and magically
5+
import their modules, but that broke code introspection.
6+
"""
7+
8+
# pylint: disable=wildcard-import
9+
110
from .applets.backup_restore.models import *
211
from .applets.collections.models import *
312
from .applets.components.models import *
@@ -6,7 +15,3 @@
615
from .applets.sections.models import *
716
from .applets.subsections.models import *
817
from .applets.units.models import *
9-
10-
# from openedx_learning.lib import appletslib
11-
12-
# globals().update(appletslib.auto_import_models())

openedx_learning/lib/appletslib.py

Lines changed: 0 additions & 54 deletions
This file was deleted.

tests/openedx_learning/apps/authoring/applets/backup_restore/test_restore.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,10 @@
77
from django.contrib.auth import get_user_model
88
from django.core.management import call_command
99

10-
from openedx_learning.apps.authoring.applets.backup_restore.zipper import LearningPackageUnzipper, generate_staged_lp_key
10+
from openedx_learning.apps.authoring.applets.backup_restore.zipper import (
11+
LearningPackageUnzipper,
12+
generate_staged_lp_key,
13+
)
1114
from openedx_learning.apps.authoring.applets.collections import api as collections_api
1215
from openedx_learning.apps.authoring.applets.components import api as components_api
1316
from openedx_learning.apps.authoring.applets.publishing import api as publishing_api

tests/openedx_learning/apps/authoring/applets/publishing/test_models.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,10 @@
33
"""
44
from typing import TYPE_CHECKING, assert_type
55

6-
from openedx_learning.apps.authoring.applets.publishing.models import PublishableEntityMixin, PublishableEntityVersionMixin
6+
from openedx_learning.apps.authoring.applets.publishing.models import (
7+
PublishableEntityMixin,
8+
PublishableEntityVersionMixin,
9+
)
710
from openedx_learning.lib.managers import WithRelationsManager
811

912
if TYPE_CHECKING:

0 commit comments

Comments
 (0)