From a9d8e72cbebda9df4212ad5b4b413e5ee4b2f0d4 Mon Sep 17 00:00:00 2001 From: "Adolfo R. Brandes" Date: Tue, 21 Apr 2026 17:40:47 -0300 Subject: [PATCH] fix: adopt frontend-base shell style manifest The shell stylesheet moved from a SCSS file to a JS manifest at @openedx/frontend-base/shell/style. Imports it directly from site.config.dev.tsx and drops the now-redundant site.scss. Mirrors openedx/frontend-base#232. Co-Authored-By: Claude --- package-lock.json | 21 ++++++++++++--------- site.config.dev.tsx | 2 +- src/app.scss | 1 - 3 files changed, 13 insertions(+), 11 deletions(-) delete mode 100644 src/app.scss diff --git a/package-lock.json b/package-lock.json index 5ee7c1b..2dc3016 100644 --- a/package-lock.json +++ b/package-lock.json @@ -41,7 +41,6 @@ "@openedx/frontend-base": "^1.0.0-alpha || 0.0.0-dev", "@openedx/paragon": "^23", "@tanstack/react-query": "^5", - "prop-types": "^15.5.10", "react": "^18", "react-dom": "^18", "react-router": "^6", @@ -4994,9 +4993,9 @@ } }, "node_modules/@openedx/frontend-base": { - "version": "1.0.0-alpha.27", - "resolved": "https://registry.npmjs.org/@openedx/frontend-base/-/frontend-base-1.0.0-alpha.27.tgz", - "integrity": "sha512-86rbiHyAoNCa+aGShO5jPQgYrjJMRG58VmNG+q7cA3fMkqzOawX9GKjbpoSxEeLiUXt3ZflrbKHEpUBPYLtBwg==", + "version": "1.0.0-alpha.33", + "resolved": "https://registry.npmjs.org/@openedx/frontend-base/-/frontend-base-1.0.0-alpha.33.tgz", + "integrity": "sha512-eTjdN4tx4zdUA0IgtEKDE4reYsG0ZLsSc62eFXyt1kbHj6UaKEn0WjPotp/2zDLMsk+BcQ7V/LQEVps6FRGK7Q==", "license": "AGPL-3.0", "peer": true, "dependencies": { @@ -5039,7 +5038,7 @@ "glob": "^7.2.3", "globals": "^15.11.0", "gradient-string": "^2.0.2", - "html-webpack-plugin": "5.6.0", + "html-webpack-plugin": "5.6.7", "identity-obj-proxy": "3.0.0", "image-minimizer-webpack-plugin": "3.8.3", "jest": "^29.7.0", @@ -12344,6 +12343,7 @@ "resolved": "https://registry.npmjs.org/fastest-levenshtein/-/fastest-levenshtein-1.0.16.tgz", "integrity": "sha512-eRnCtTTtGZFpQCwhJiUOuxPQWRXVKYDn0b2PeHfXL6/Zi53SLAzAHfVhVWK2AryC/WH05kGfxhFIPvTF0SXQzg==", "license": "MIT", + "peer": true, "engines": { "node": ">= 4.9.1" } @@ -13745,9 +13745,9 @@ } }, "node_modules/html-webpack-plugin": { - "version": "5.6.0", - "resolved": "https://registry.npmjs.org/html-webpack-plugin/-/html-webpack-plugin-5.6.0.tgz", - "integrity": "sha512-iwaY4wzbe48AfKLZ/Cc8k0L+FKG6oSNRaZ8x5A/T/IVDGyXcbHncM9TdDa93wn0FsSm82FhTKW7f3vS61thXAw==", + "version": "5.6.7", + "resolved": "https://registry.npmjs.org/html-webpack-plugin/-/html-webpack-plugin-5.6.7.tgz", + "integrity": "sha512-md+vXtdCAe60s1k6AU3dUyMJnDxUyQAwfwPKoLisvgUF1IXjtlLsk2se54+qfL9Mdm26bbwvjJybpNx48NKRLw==", "license": "MIT", "peer": true, "dependencies": { @@ -17677,6 +17677,7 @@ "resolved": "https://registry.npmjs.org/minipass/-/minipass-7.1.3.tgz", "integrity": "sha512-tEBHqDnIoM/1rXME1zgka9g6Q2lcoCkxHLuc7ODJ5BxbP5d4c2Z5cGgtXAku59200Cx7diuHTOYfSBD8n6mm8A==", "license": "BlueOak-1.0.0", + "peer": true, "engines": { "node": ">=16 || 14 >=14.17" } @@ -20382,6 +20383,7 @@ "resolved": "https://registry.npmjs.org/p-map/-/p-map-2.1.0.tgz", "integrity": "sha512-y3b8Kpd8OAN444hxfBbFfj1FY/RjtTd8tzYwhUqNYXx0fXx2iX4maP4Qr6qhIKbQXI02wTLAda4fYUbDagTUFw==", "license": "MIT", + "peer": true, "engines": { "node": ">=6" } @@ -26485,7 +26487,8 @@ "version": "0.2.0", "resolved": "https://registry.npmjs.org/text-table/-/text-table-0.2.0.tgz", "integrity": "sha512-N+8UisAXDGk8PFXP4HAzVR9nbfmVJ3zYLAWiTIoqC5v5isinhr+r5uaO8+7r3BMfuNIufIsA7RdpVgacC2cSpw==", - "license": "MIT" + "license": "MIT", + "peer": true }, "node_modules/thenify": { "version": "3.3.1", diff --git a/site.config.dev.tsx b/site.config.dev.tsx index 53a8a79..06b49d0 100644 --- a/site.config.dev.tsx +++ b/site.config.dev.tsx @@ -9,7 +9,7 @@ import { import notificationsApp from './src/app'; import devApp from './dev'; -import './src/app.scss'; +import '@openedx/frontend-base/shell/style'; const siteConfig: SiteConfig = { siteId: 'notifications-dev', diff --git a/src/app.scss b/src/app.scss deleted file mode 100644 index defee90..0000000 --- a/src/app.scss +++ /dev/null @@ -1 +0,0 @@ -@use "@openedx/frontend-base/shell/app.scss";