Skip to content

Commit bb3a9b7

Browse files
committed
fix: add min height to all library blocks
1 parent 5ecb5bf commit bb3a9b7

3 files changed

Lines changed: 13 additions & 4 deletions

File tree

src/editors/AdvancedEditor.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ const AdvancedEditor = ({ usageKey, onClose }: AdvancedEditorProps) => {
5555
usageKey={usageKey}
5656
view="studio_view"
5757
scrolling="yes"
58+
minHeight="70vh"
5859
/>
5960
</IframeProvider>
6061
</EditorModalWrapper>

src/library-authoring/component-comparison/CompareChangesWidget.tsx

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,22 @@ const CompareChangesWidget = ({ usageKey, oldVersion = 'published', newVersion =
2929
<Tab eventKey="old" title={intl.formatMessage(messages.oldVersionTitle)}>
3030
<div className="p-2 bg-white">
3131
<IframeProvider>
32-
<LibraryBlock usageKey={usageKey} version={oldVersion} />
32+
<LibraryBlock
33+
usageKey={usageKey}
34+
version={oldVersion}
35+
minHeight="50vh"
36+
/>
3337
</IframeProvider>
3438
</div>
3539
</Tab>
3640
<Tab eventKey="new" title={intl.formatMessage(messages.newVersionTitle)}>
3741
<div className="p-2 bg-white">
3842
<IframeProvider>
39-
<LibraryBlock usageKey={usageKey} version={newVersion} />
43+
<LibraryBlock
44+
usageKey={usageKey}
45+
version={newVersion}
46+
minHeight="50vh"
47+
/>
4048
</IframeProvider>
4149
</div>
4250
</Tab>

src/library-authoring/component-info/ComponentPreview.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ const ModalComponentPreview = ({ isOpen, close, usageKey }: ModalComponentPrevie
3131
<LibraryBlock
3232
usageKey={usageKey}
3333
version={showOnlyPublished ? 'published' : undefined}
34-
minHeight="70vh"
34+
minHeight="60vh"
3535
/>
3636
</StandardModal>
3737
);
@@ -72,7 +72,7 @@ const ComponentPreview = () => {
7272
usageKey={usageKey}
7373
key={componentMetadata.modified}
7474
version={showOnlyPublished ? 'published' : undefined}
75-
minHeight="70vh"
75+
minHeight="60vh"
7676
/>
7777
)
7878
: null

0 commit comments

Comments
 (0)