feat(gui): sync workspace config and rerun artifacts#89
Open
KoEkko wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
refresh_configandsync_config, including renderer APIs and shared command contracts.eccsubmodule pointer and Bazel@eccpackaged CLI override to ECC PR #113 commit125e39c, so GUI AppImage CI builds package the matching CLI changes before the ECC PR lands.Commits
fix(gui): use source-tree ecc venv in developmentfeat(gui): add workspace config sync bridgerefresh_configandsync_config.feat(gui): guard active config savesfeat(gui): reset rerun artifacts during flow restartchore(gui): update ecc submodule for workspace syncbuild(gui): pin packaged ecc cli to workspace sync commit@ecc//:build_ecc_cli_bundleat the same ECC companion commit and refreshes the Bazel module lock digests, so AppImage packaging uses the matching CLI bundle.Tests
pnpm exec vitest run electron/services/eccCliRuntime.test.ts electron/services/desktopRuntimeManager.test.ts electron/services/eccCliAdapter.test.ts electron/services/workspaceService.test.ts --silentfromecos/gui/apps/desktop-electronpnpm exec vitest run src/api/flow.desktop-ipc.test.ts src/api/runtimeEvents.desktop-cli.test.ts src/composables/useFlowRunner.test.ts src/composables/useFlowRunMode.test.ts src/composables/useFlowStages.live-watch.test.ts src/composables/useHomeData.live-watch.test.ts src/composables/useParameters.runtime.test.ts src/composables/useStepConfigInfo.test.ts src/composables/useWorkspace.test.ts --silentfromecos/gui/apps/renderer.venv/bin/python -m chipcompiler.cli.main workspace refresh-config --help,.venv/bin/python -m chipcompiler.cli.main workspace sync-config --help, and.venv/bin/python -m chipcompiler.cli.main workspace run-flow --helpfromeccpython3 - <<'PY' ...check thatMODULE.bazelpins@eccto125e39c6559b4440d79505a3685b6b04a28519f9bazel cquery --output=label @ecc//:build_ecc_cli_bundlegit diff --check HEAD~1..HEADRelated PRs
Notes
eccsubmodule and the Bazel packaged CLI input at ECC companion PR branch commit125e39c6559b4440d79505a3685b6b04a28519f9. After ECC #113 merges, reconcile both pointers to the merged ECC commit if GitHub creates a different merge commit.