feat: track e2e dependencies#561
Conversation
📝 WalkthroughWalkthroughMakefile now exports CERTMANAGER_VERSION, TRUSTMANAGER_VERSION, and ZOT_VERSION. hack/dev-cluster.sh requires and uses those variables for versioned Helm installs (including OCI chart URLs and --version flags). renovate.json adds regex customManagers to detect and update those Makefile variables from upstream releases. ChangesComponent version parameterization and automation
🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers:
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Coverage Report for CI Build 26643092100Coverage decreased (-0.4%) to 71.677%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions15 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
hack/dev-cluster.sh (1)
5-14:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winGuard the new version variables (script is no longer standalone-runnable).
With
set -uactive, the new${CERTMANAGER_VERSION},${TRUSTMANAGER_VERSION}, and${ZOT_VERSION}references (Lines 34, 67, 91/95, 107/111) abort with a cryptic "unbound variable" if the script is invoked directly rather than through the make targets that export them. The versions used to be hardcoded, so direct execution previously worked. Add explicit guards here so the failure is clear and the variable-handling stays consistent with the rest of this block.🛡️ Proposed guards
YQ="${YQ:-yq}" + +# Versions are exported by the Makefile; fail fast with a clear message when run standalone. +CERTMANAGER_VERSION="${CERTMANAGER_VERSION:?must be set (see Makefile)}" +TRUSTMANAGER_VERSION="${TRUSTMANAGER_VERSION:?must be set (see Makefile)}" +ZOT_VERSION="${ZOT_VERSION:?must be set (see Makefile)}"🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@hack/dev-cluster.sh` around lines 5 - 14, The script now references CERTMANAGER_VERSION, TRUSTMANAGER_VERSION, and ZOT_VERSION without defaults which breaks under set -u; add the same guarded default assignments used for KIND_CLUSTER/TAG (e.g. set CERTMANAGER_VERSION, TRUSTMANAGER_VERSION, ZOT_VERSION using parameter expansion defaults) at the top of hack/dev-cluster.sh so direct invocation won’t hit "unbound variable" errors and behavior remains consistent with the rest of the environment-variable block.
🧹 Nitpick comments (1)
Makefile (1)
16-18: 💤 Low valueNote the assignment-operator coupling with
renovate.json.These use
:=while the other version pins (OCM_DEMO_VERSION,ENVTEST_K8S_VERSION) use?=. That's fine here, but be aware the RenovatecustomManagersmatchStringshardcode:=, so switching these to?=later would silently break version tracking. Worth a brief comment to prevent accidental drift.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Makefile` around lines 16 - 18, The three version exports (CERTMANAGER_VERSION, TRUSTMANAGER_VERSION, ZOT_VERSION) use the ':=' assignment which is required by Renovate's customManagers matchStrings; add a brief inline comment above or beside these exports stating they must remain ':=' (not '?=') to keep Renovate version detection working, referencing the Renovate pattern (customManagers matchStrings expecting " :=") so future edits don't accidentally switch the operator.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@hack/dev-cluster.sh`:
- Around line 5-14: The script now references CERTMANAGER_VERSION,
TRUSTMANAGER_VERSION, and ZOT_VERSION without defaults which breaks under set
-u; add the same guarded default assignments used for KIND_CLUSTER/TAG (e.g. set
CERTMANAGER_VERSION, TRUSTMANAGER_VERSION, ZOT_VERSION using parameter expansion
defaults) at the top of hack/dev-cluster.sh so direct invocation won’t hit
"unbound variable" errors and behavior remains consistent with the rest of the
environment-variable block.
---
Nitpick comments:
In `@Makefile`:
- Around line 16-18: The three version exports (CERTMANAGER_VERSION,
TRUSTMANAGER_VERSION, ZOT_VERSION) use the ':=' assignment which is required by
Renovate's customManagers matchStrings; add a brief inline comment above or
beside these exports stating they must remain ':=' (not '?=') to keep Renovate
version detection working, referencing the Renovate pattern (customManagers
matchStrings expecting " :=") so future edits don't accidentally switch the
operator.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: ad58f3cd-93fc-4268-a7fc-e6958581fc88
📒 Files selected for processing (3)
Makefilehack/dev-cluster.shrenovate.json
olzemal
force-pushed
the
feature/track-e2e-dependencies
branch
from
5228f68 to
99c6405
Compare
4 participants
What
related to opendefensecloud/artifact-conduit#386
Why
Currently e2e depedencies like cert-manager or zot are not tracked by renovate
Testing
Checklist
Tests added/updatedn/aSummary by CodeRabbit