Skip to content

chore: use ociArtifact for argo-workflows helm chart resource#93

Merged
dermorz merged 1 commit into
mainfrom
chore/use-argo-workflows-oci-helmchart
Jun 9, 2026
Merged

chore: use ociArtifact for argo-workflows helm chart resource#93
dermorz merged 1 commit into
mainfrom
chore/use-argo-workflows-oci-helmchart

Conversation

@dermorz

@dermorz dermorz commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

What

Switch argo-workflows-chart from HTTP helm repository to OCI artifact reference.
Closes #

Why

The type: helm HTTP reference caused the chart to be embedded as a localBlob inside the OCM component on transfer to an OCI registry, making it unaddressable as a standalone OCI artifact. This broke the standard Flux OCIRepository/HelmRelease consumption pattern — the chart had to be installed via ocm download resources + helm install instead.

Testing

  • Built component locally: ocm add componentversion --version 1.0.14 --create --file ./ctf component-constructor.yaml
  • Verified build succeeds and CTF localBlob storage matches the flux reference component (expected CTF behaviour)

Notes for reviewers

The argoproj Helm charts are published to OCI at ghcr.io/argoproj/argo-helm/argo-workflows. This matches the access pattern already used by arc and flux components in this repo.

Checklist

  • Manually tested
  • No breaking changes (or upgrade path documented above)
  • Readable commit history (squashed and cleaned up as desired)
  • AI code review considered and comments resolved

Summary by CodeRabbit

  • Chores
    • Updated Argo Workflows dependency source while maintaining the same version.

@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The pull request updates the Argo Workflows chart dependency in argo-workflows/component-constructor.yaml from a Helm chart repository reference to an OCI artifact reference, maintaining version 1.0.14 while changing the source from the traditional Helm repository to a container registry image.

Changes

Argo Workflows Chart Dependency Update

Layer / File(s) Summary
Argo Workflows chart OCI artifact reference
argo-workflows/component-constructor.yaml
The argo-workflows-chart dependency migrates from type: helm with helmChart/helmRepository pointing to https://argoproj.github.io/argo-helm to type: ociArtifact referencing ghcr.io/argoproj/argo-helm/argo-workflows:1.0.14.

Possibly related PRs

Suggested reviewers

  • trevex
  • olzemal

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Poem

🐰 From Helm repos to registries we hop,
OCI artifacts make the migrations pop,
Version stable at one-point-oh-four,
Chart sources dance to containers at the core! 📦✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: switching argo-workflows to use an OCI artifact instead of HTTP Helm repository.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The pull request description closely follows the template with all required sections completed: What, Why, Testing, Notes for reviewers, and Checklist items.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/use-argo-workflows-oci-helmchart

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dermorz dermorz merged commit 7718fbc into main Jun 9, 2026
2 checks passed
@dermorz dermorz deleted the chore/use-argo-workflows-oci-helmchart branch June 9, 2026 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants