fix: register helm values templates for argo-workflows and arc

[dermorz]

What

Fix ocm-kit "helm values template not found" error for argo-workflows and artifact-conduit by registering missing values-template resources.

Why

ocm-kit locates its Helm values template by scanning for a yaml-typed resource carrying the label opendefense.cloud/helm/values-for: <chart-resource-name>. Neither argo-workflows nor artifact-conduit declared such a resource, so ocm-kit failed with:

Error: failed to get helm values template: failed to find first helm values template: not found

flux, solution-arsenal, zot, ocm-demo, and solution-arsenal-discovery all follow a consistent pattern — a dedicated <chart>-values-template resource (separate from the *-minimal-config/*-production-config profiles) carrying the label and pointing at a values.yaml.tpl that injects localized image references via .OCIResources. This PR brings both components in line with that pattern:

• argo-workflows already had an orphaned values.yaml.tpl (added in a prior commit but never wired up) — it's now registered as argo-workflows-chart-values-template.
• artifact-conduit had no template file at all — added a new values.yaml.tpl (modeled on argo-workflows'/flux's) templating apiserver, controller, and etcd image refs, and registered it as arc-chart-values-template.

Testing

• Built both components locally with ocm add componentversion --create --file ./ctf component-constructor.yaml and confirmed they succeed.
• Verified via ocm get resources that argo-workflows-chart-values-template and arc-chart-values-template are present and carry the opendefense.cloud/helm/values-for label pointing at the correct chart resource.
• Downloaded the packaged template resources from the built CTFs and confirmed their content matches the source values.yaml.tpl files byte-for-byte.

Notes for reviewers

No CRD/API/RBAC changes. Purely additive — new yaml resources and one new template file; existing minimal-config/production-config
resources are untouched (kept unlabeled, consistent with precedent).

Checklist

• Manually tested
• No breaking changes (or upgrade path documented above)
• Readable commit history (squashed and cleaned up as desired)
• AI code review considered and comments resolved

Summary by CodeRabbit

• Chores
  • Added Helm values configuration templates for argo-workflows and artifact-conduit services.
  • Enabled image configuration support for apiserver, controller, and etcd components.

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR introduces Helm values templates for managing container image configuration across Argo Workflows and Artifact-Conduit charts. It adds a new values.yaml.tpl template for Artifact-Conduit and wires both charts via new component constructor entries that reference template files sourced from .OCIResources.

Changes

Helm Values Template Configuration

Layer / File(s)	Summary
Artifact-Conduit values template implementation artifact-conduit/values.yaml.tpl	New Helm template that derives image configuration for apiserver, controller, and etcd components by pulling Host, Repository, and Tag from .OCIResources entries and rendering them as image.repository and image.tag.
Component constructor wiring for value templates artifact-conduit/component-constructor.yaml, argo-workflows/component-constructor.yaml	Adds arc-chart-values-template (v0.2.2) and argo-workflows-chart-values-template (v1.0.14) local YAML component definitions that reference their respective values.yaml.tpl template files.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• opendefensecloud/ocm-components#89: Both PRs add/update Argo Workflows Helm chart value templating in argo-workflows/component-constructor.yaml by wiring a local values.yaml.tpl-backed *-chart-values-template (chart version 1.0.14) into the component.

Suggested reviewers

• trevex
• yocaba

Poem

🐰 Charts and templates, oh what a sight,
OCIResources flowing just right,
Argo and Artifact, both dressed so fine,
With values templated in perfect design!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: registering helm values templates for two components (argo-workflows and arc) to fix a missing resource issue.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description check	✅ Passed	The pull request description comprehensively addresses all required template sections with clear context, testing details, and proper checklist completion.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/ocm-kit-values-template-label

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}