refactor: migrate fmt.Print to ui helpers, tighten fmtprint archtest to near-hard rule (#113)

* refactor: migrate fmt.Print to ui helpers, tighten fmtprint archtest to near-hard rule

* chore: trigger CI

Author: fullstackjam

docs/HARNESS.md

@@ -46,6 +46,7 @@ Three regulation categories:
 | Arch. | `no-raw-http` | L1 | `internal/archtest/http_test.go` |
 | Arch. | `no-os-getenv-home` | L1 | `internal/archtest/envhome_test.go` |
 | Arch. | `dryrun` — destructive ops must check `DryRun` | L1 | `internal/archtest/dryrun_test.go` |
+| Arch. | `no-raw-fmtprint` — UI output via `ui.*` helpers, not raw `fmt.Print*` | L1 | `internal/archtest/fmtprint_test.go` |
 | Behav. | L1 unit + integration + contract (faked runners *and* real brew/git/npm in temp dirs) | pre-push, CI | `make test-unit` |
 | Behav. | L2 contract schema (against openboot-contract repo) | CI | `.github/workflows/test.yml` `contract` job |
 | Behav. | L3 e2e binary | release | `make test-e2e` |

internal/archtest/baseline/fmtprint.txt

@@ -1,134 +1,6 @@
 # Baseline for archtest rule "fmtprint".
 # Each line is <file>:<line> of a known existing violation.
 # Regenerate: ARCHTEST_UPDATE_BASELINE=1 go test ./internal/archtest/...
-internal/brew/brew_install.go:133
-internal/brew/brew_install.go:221
-internal/brew/brew_install.go:231
-internal/brew/brew_install.go:238
-internal/brew/brew_install.go:270
-internal/brew/brew_install.go:274
-internal/brew/brew_install.go:276
-internal/cli/install.go:368
-internal/cli/install.go:372
-internal/cli/install.go:393
-internal/cli/install.go:405
-internal/cli/install.go:477
-internal/cli/install.go:484
-internal/cli/root.go:86
-internal/cli/snapshot.go:256
-internal/cli/sync_helpers.go:45
-internal/cli/sync_helpers.go:50
-internal/cli/sync_helpers.go:54
-internal/cli/sync_helpers.go:60
-internal/cli/sync_helpers.go:62
-internal/cli/sync_helpers.go:66
-internal/cli/sync_helpers.go:72
-internal/cli/sync_helpers.go:79
-internal/cli/sync_helpers.go:81
-internal/cli/sync_helpers.go:85
-internal/cli/sync_helpers.go:86
-internal/cli/sync_helpers.go:87
-internal/cli/sync_helpers.go:95
-internal/cli/update.go:104
-internal/diff/format.go:14
-internal/diff/format.go:16
-internal/diff/format.go:19
-internal/diff/format.go:97
-internal/diff/format.go:99
-internal/diff/format.go:102
-internal/diff/format.go:105
-internal/diff/format.go:107
-internal/diff/format.go:116
-internal/diff/format.go:118
-internal/diff/format.go:122
-internal/diff/format.go:125
-internal/diff/format.go:127
-internal/diff/format.go:136
-internal/diff/format.go:138
-internal/diff/format.go:142
-internal/diff/format.go:146
-internal/diff/format.go:149
-internal/diff/format.go:158
-internal/diff/format.go:160
-internal/diff/format.go:164
-internal/diff/format.go:167
-internal/diff/format.go:169
-internal/diff/format.go:176
-internal/diff/format.go:182
-internal/diff/format.go:190
-internal/diff/format.go:193
-internal/diff/format.go:204
-internal/diff/format.go:209
-internal/dotfiles/dotfiles.go:79
-internal/dotfiles/dotfiles.go:116
-internal/dotfiles/dotfiles.go:130
-internal/dotfiles/dotfiles.go:203
-internal/dotfiles/dotfiles.go:207
-internal/dotfiles/dotfiles.go:271
-internal/dotfiles/dotfiles.go:437
-internal/dotfiles/dotfiles.go:440
-internal/dotfiles/dotfiles.go:444
-internal/dotfiles/dotfiles.go:446
-internal/installer/installer.go:48
-internal/installer/installer.go:50
-internal/installer/installer.go:54
-internal/installer/installer.go:128
-internal/installer/installer.go:134
-internal/installer/installer.go:140
-internal/installer/installer.go:151
-internal/installer/installer.go:158
-internal/installer/installer.go:183
-internal/installer/installer.go:192
-internal/installer/installer.go:204
-internal/installer/installer.go:214
-internal/installer/installer.go:216
-internal/installer/installer.go:220
-internal/installer/installer.go:231
-internal/installer/installer.go:241
-internal/installer/installer.go:302
-internal/installer/installer.go:304
-internal/installer/installer.go:307
-internal/installer/installer.go:337
-internal/installer/step_git.go:12
-internal/installer/step_git.go:17
-internal/installer/step_git.go:23
-internal/installer/step_git.go:36
-internal/installer/step_packages.go:77
-internal/installer/step_packages.go:83
-internal/installer/step_packages.go:134
-internal/installer/step_packages.go:139
-internal/installer/step_packages.go:161
-internal/installer/step_packages.go:207
-internal/installer/step_packages.go:209
-internal/installer/step_packages.go:211
-internal/installer/step_packages.go:229
-internal/installer/step_shell.go:17
-internal/installer/step_shell.go:40
-internal/installer/step_shell.go:58
-internal/installer/step_shell.go:89
-internal/installer/step_system.go:20
-internal/installer/step_system.go:24
-internal/installer/step_system.go:38
-internal/installer/step_system.go:48
-internal/installer/step_system.go:52
-internal/installer/step_system.go:58
-internal/installer/step_system.go:60
-internal/installer/step_system.go:69
-internal/installer/step_system.go:76
-internal/installer/step_system.go:90
-internal/installer/step_system.go:94
 internal/macos/macos.go:94
 internal/macos/macos.go:141
 internal/macos/macos.go:153
-internal/npm/npm.go:112
-internal/npm/npm.go:128
-internal/npm/npm.go:131
-internal/npm/npm.go:164
-internal/npm/npm.go:182
-internal/shell/shell.go:200
-internal/shell/shell.go:203
-internal/updater/updater.go:189
-internal/updater/updater.go:234
-internal/updater/updater.go:239
-internal/updater/updater.go:251
-internal/updater/updater.go:255

internal/archtest/fmtprint_test.go

@@ -32,10 +32,19 @@ func isOsStderr(gf goFile, expr ast.Expr) bool {
 	return local != "" && ident.Name == local
 }
 
+// isAddressOf reports whether expr is a unary & expression (e.g. &sb).
+// Writes to an address-of receiver are local buffer writes (strings.Builder,
+// bytes.Buffer, etc.), not user-visible output — exempt from the rule.
+func isAddressOf(expr ast.Expr) bool {
+	unary, ok := expr.(*ast.UnaryExpr)
+	return ok && unary.Op.String() == "&"
+}
+
 // findFmtPrint finds forbidden fmt.Print*/fmt.F* calls in gf.
 //   - fmt.Print, fmt.Println, fmt.Printf: always forbidden (stdout only).
 //   - fmt.Fprint, fmt.Fprintln, fmt.Fprintf: forbidden unless first argument
-//     is os.Stderr (stderr is acceptable for debug/error output).
+//     is os.Stderr (stderr is acceptable for debug/error output) or an
+//     address-of expression like &sb (local buffer, not user output).
 func findFmtPrint(gf goFile) []callSite {
 	local := importedAs(gf.file, "fmt")
 	if local == "" {
@@ -49,7 +58,7 @@ func findFmtPrint(gf goFile) []callSite {
 		"Printf":  true,
 	}
 	// writerFuncs take an io.Writer as first arg — forbidden unless that writer
-	// is os.Stderr.
+	// is os.Stderr or a local buffer (&sb, &buf, etc.).
 	writerFuncs := map[string]bool{
 		"Fprint":   true,
 		"Fprintln": true,
@@ -77,11 +86,12 @@ func findFmtPrint(gf goFile) []callSite {
 			return true
 		}
 		if writerFuncs[fn] {
-			// Only flag if the first argument is NOT os.Stderr.
-			if len(call.Args) == 0 || !isOsStderr(gf, call.Args[0]) {
-				p := gf.fset.Position(call.Pos())
-				out = append(out, callSite{file: gf.path, line: p.Line})
+			// Exempt: os.Stderr (debug/error output) and &var (local buffer).
+			if len(call.Args) > 0 && (isOsStderr(gf, call.Args[0]) || isAddressOf(call.Args[0])) {
+				return true
 			}
+			p := gf.fset.Position(call.Pos())
+			out = append(out, callSite{file: gf.path, line: p.Line})
 			return true
 		}
 		return true

internal/brew/brew_install.go

@@ -130,7 +130,7 @@ func InstallWithProgress(ctx context.Context, cliPkgs, caskPkgs []string, dryRun
 	skipped := total - len(newCli) - len(newCask)
 	if skipped > 0 {
 		ui.Muted(fmt.Sprintf("  %d already installed, %d to install", skipped, len(newCli)+len(newCask)))
-		fmt.Println()
+		ui.Println()
 	}
 
 	if len(newCli)+len(newCask) == 0 {
@@ -218,7 +218,7 @@ func retryFailedJobs(ctx context.Context, allFailed []failedJob, installedFormul
 		return nil
 	}
 
-	fmt.Printf("\nRetrying %d failed packages...\n", len(allFailed))
+	ui.Printf("\nRetrying %d failed packages...\n", len(allFailed))
 
 	for _, f := range allFailed {
 		var errMsg string
@@ -228,14 +228,14 @@ func retryFailedJobs(ctx context.Context, allFailed []failedJob, installedFormul
 			errMsg = installFormulaWithError(ctx, f.name)
 		}
 		if errMsg == "" {
-			fmt.Printf("  ✔ %s (retry succeeded)\n", f.name)
+			ui.Printf("  ✔ %s (retry succeeded)\n", f.name)
 			if f.isCask {
 				*installedCasks = append(*installedCasks, f.name)
 			} else {
 				*installedFormulae = append(*installedFormulae, aliasMap[f.name])
 			}
 		} else {
-			fmt.Printf("  ✗ %s (still failed)\n", f.name)
+			ui.Printf("  ✗ %s (still failed)\n", f.name)
 		}
 	}
 
@@ -267,13 +267,13 @@ func handleFailedJobs(failed []failedJob) {
 		return
 	}
 
-	fmt.Println()
+	ui.Println()
 	ui.Error(fmt.Sprintf("%d packages failed to install:", len(failed)))
 	for _, f := range failed {
 		if f.errMsg != "" {
-			fmt.Printf("    - %s (%s)\n", f.name, f.errMsg)
+			ui.Printf("    - %s (%s)\n", f.name, f.errMsg)
 		} else {
-			fmt.Printf("    - %s\n", f.name)
+			ui.Printf("    - %s\n", f.name)
 		}
 	}
 }

internal/cli/install.go

@@ -365,11 +365,11 @@ func runSyncInstall(source *syncpkg.SyncSource, pickRaw string) error { //nolint
 		}
 	}
 
-	fmt.Println()
+	ui.Println()
 	plan := buildInstallPlan(diff, rc)
 	result, execErr := syncpkg.Execute(plan, false)
 
-	fmt.Println()
+	ui.Println()
 	if result.Installed > 0 {
 		ui.Success(fmt.Sprintf("Installed %d package(s)", result.Installed))
 	}
@@ -390,7 +390,7 @@ func runSyncInstall(source *syncpkg.SyncSource, pickRaw string) error { //nolint
 // the top of a sync-source install. Warns in yellow if > 90 days stale.
 func printSyncSourceHeader(source *syncpkg.SyncSource) {
 	label := sourceLabel(source)
-	fmt.Println()
+	ui.Println()
 	if source.SyncedAt.IsZero() {
 		ui.Info(fmt.Sprintf("→ Syncing with %s", label))
 	} else {
@@ -402,7 +402,7 @@ func printSyncSourceHeader(source *syncpkg.SyncSource) {
 			ui.Info(fmt.Sprintf("→ Syncing with %s (last synced %s)", label, rel))
 		}
 	}
-	fmt.Println()
+	ui.Println()
 }
 
 // applyPickFlagToRemoteConfig filters rc to the packages named in pickRaw.
@@ -474,14 +474,14 @@ func filterStrings(in []string, keep map[string]bool) []string {
 // config. Returns the rc to install (possibly filtered by user's picks) and
 // whether the user wants to continue. When cancelled, returns (nil, false, nil).
 func promptCustomizeAndApply(rc *config.RemoteConfig) (*config.RemoteConfig, bool, error) {
-	fmt.Println()
+	ui.Println()
 	ui.Info(fmt.Sprintf("→ %s/%s", rc.Username, rc.Slug))
 	ui.Muted(fmt.Sprintf("  CLI tools: %d", len(rc.Packages)))
 	ui.Muted(fmt.Sprintf("  Apps: %d", len(rc.Casks)))
 	if len(rc.Npm) > 0 {
 		ui.Muted(fmt.Sprintf("  npm: %d", len(rc.Npm)))
 	}
-	fmt.Println()
+	ui.Println()
 
 	choice, err := ui.SelectOption(
 		fmt.Sprintf("Install %d packages?", len(rc.Packages)+len(rc.Casks)+len(rc.Npm)),

internal/cli/root.go

@@ -11,6 +11,7 @@ import (
 
 	"github.com/openbootdotdev/openboot/internal/config"
 	"github.com/openbootdotdev/openboot/internal/logging"
+	"github.com/openbootdotdev/openboot/internal/ui"
 	"github.com/openbootdotdev/openboot/internal/updater"
 )
 
@@ -83,7 +84,7 @@ var versionCmd = &cobra.Command{
 	Use:   "version",
 	Short: "Print version information",
 	Run: func(cmd *cobra.Command, args []string) {
-		fmt.Printf("OpenBoot v%s\n", version)
+		ui.Printf("OpenBoot v%s\n", version)
 	},
 }
 

internal/cli/snapshot.go

@@ -253,7 +253,7 @@ func captureJSONSnapshot() error {
 		return fmt.Errorf("marshal snapshot: %w", err)
 	}
 	fmt.Fprintln(os.Stderr, "✓ Snapshot complete")
-	fmt.Println(string(data))
+	ui.Println(string(data))
 	return nil
 }
 

internal/cli/sync_helpers.go

@@ -42,57 +42,57 @@ func printInstallDiff(d *syncpkg.SyncDiff) {
 		len(d.MissingNpm) > 0 || len(d.MissingTaps) > 0
 
 	if hasPkgAdditions {
-		fmt.Printf("  %s\n", ui.Green("Packages to install"))
+		ui.Printf("  %s\n", ui.Green("Packages to install"))
 		printMissing("Formulae", d.MissingFormulae)
 		printMissing("Casks", d.MissingCasks)
 		printMissing("NPM", d.MissingNpm)
 		printMissing("Taps", d.MissingTaps)
-		fmt.Println()
+		ui.Println()
 	}
 
 	if len(d.MacOSChanged) > 0 {
-		fmt.Printf("  %s\n", ui.Green("macOS Changes"))
+		ui.Printf("  %s\n", ui.Green("macOS Changes"))
 		for _, p := range d.MacOSChanged {
 			desc := p.Desc
 			if desc == "" {
 				desc = fmt.Sprintf("%s.%s", p.Domain, p.Key)
 			}
-			fmt.Printf("    %s: %s %s %s\n", desc, p.LocalValue, ui.Yellow("→"), p.RemoteValue)
+			ui.Printf("    %s: %s %s %s\n", desc, p.LocalValue, ui.Yellow("→"), p.RemoteValue)
 		}
-		fmt.Println()
+		ui.Println()
 	}
 
 	if d.Shell != nil {
-		fmt.Printf("  %s\n", ui.Green("Shell Changes"))
+		ui.Printf("  %s\n", ui.Green("Shell Changes"))
 		if d.Shell.ThemeChanged {
 			localTheme := d.Shell.LocalTheme
 			if localTheme == "" {
 				localTheme = "(none)"
 			}
-			fmt.Printf("    Theme: %s %s %s\n", localTheme, ui.Yellow("→"), d.Shell.RemoteTheme)
+			ui.Printf("    Theme: %s %s %s\n", localTheme, ui.Yellow("→"), d.Shell.RemoteTheme)
 		}
 		if d.Shell.PluginsChanged {
 			localPlugins := strings.Join(d.Shell.LocalPlugins, ", ")
 			if localPlugins == "" {
 				localPlugins = "(none)"
 			}
-			fmt.Printf("    Plugins: %s %s %s\n", localPlugins, ui.Yellow("→"), strings.Join(d.Shell.RemotePlugins, ", "))
+			ui.Printf("    Plugins: %s %s %s\n", localPlugins, ui.Yellow("→"), strings.Join(d.Shell.RemotePlugins, ", "))
 		}
-		fmt.Println()
+		ui.Println()
 	}
 
 	if d.DotfilesChanged {
-		fmt.Printf("  %s\n", ui.Green("Dotfiles"))
-		fmt.Printf("    Repo: %s %s %s\n", fallbackStr(d.LocalDotfiles, "(none)"), ui.Yellow("→"), d.RemoteDotfiles)
-		fmt.Println()
+		ui.Printf("  %s\n", ui.Green("Dotfiles"))
+		ui.Printf("    Repo: %s %s %s\n", fallbackStr(d.LocalDotfiles, "(none)"), ui.Yellow("→"), d.RemoteDotfiles)
+		ui.Println()
 	}
 }
 
 func printMissing(category string, missing []string) {
 	if len(missing) == 0 {
 		return
 	}
-	fmt.Printf("    %s (%d): %s\n", category, len(missing), strings.Join(missing, ", "))
+	ui.Printf("    %s (%d): %s\n", category, len(missing), strings.Join(missing, ", "))
 }
 
 func fallbackStr(s, def string) string {

internal/cli/update.go

@@ -101,7 +101,7 @@ func runListBackups() error {
 	}
 	ui.Header(fmt.Sprintf("Backups in %s", dir))
 	for _, n := range names {
-		fmt.Println("  " + n)
+		ui.Println("  " + n)
 	}
 	return nil
 }