fix: remove shell from API responses, fix packages/casks overlap

- API no longer returns `shell` field (oh_my_zsh, theme, plugins) —
  shell config is part of dotfiles, not a separate concern
- Fix packages array to only contain formulae, not casks. Previously
  casks appeared in both `packages` and `casks` arrays, causing the
  CLI diff to show false "missing" items.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: fullstackjam

src/routes/[username]/[slug]/config/+server.ts

@@ -41,7 +41,6 @@ export const GET: RequestHandler = async ({ platform, params, request }) => {
 
 	const tapsSet = new Set<string>();
 	const snapshotCasks = new Set<string>();
-	let shell: { oh_my_zsh: boolean; theme: string; plugins: string[] } | null = null;
 	let macosPrefs: { domain: string; key: string; type: string; value: string; desc: string }[] | null = null;
 
 	if (config.snapshot) {
@@ -53,13 +52,6 @@ export const GET: RequestHandler = async ({ platform, params, request }) => {
 			for (const cask of snapshot.packages?.casks || []) {
 				snapshotCasks.add(cask);
 			}
-			if (snapshot.shell) {
-				shell = {
-					oh_my_zsh: snapshot.shell.oh_my_zsh ?? false,
-					theme: snapshot.shell.theme ?? '',
-					plugins: snapshot.shell.plugins ?? []
-				};
-			}
 			if (Array.isArray(snapshot.macos_prefs) && snapshot.macos_prefs.length > 0) {
 				const filtered = snapshot.macos_prefs.filter(
 					(p: unknown): p is { domain: string; key: string; type: string; value: string; desc: string } =>
@@ -89,18 +81,18 @@ export const GET: RequestHandler = async ({ platform, params, request }) => {
 
 	for (const pkg of rawPackages) {
 		if (typeof pkg === 'string') {
-			packageNames.push(pkg);
 			if (snapshotCasks.has(pkg)) {
 				caskNames.push(pkg);
+			} else {
+				packageNames.push(pkg);
 			}
 		} else {
 			if (pkg.type === 'npm') {
 				npmNames.push(pkg.name);
+			} else if (pkg.type === 'cask') {
+				caskNames.push(pkg.name);
 			} else {
 				packageNames.push(pkg.name);
-				if (pkg.type === 'cask') {
-					caskNames.push(pkg.name);
-				}
 			}
 		}
 	}
@@ -127,7 +119,6 @@ export const GET: RequestHandler = async ({ platform, params, request }) => {
 		post_install: config.custom_script
 			? config.custom_script.split('\n').map((s: string) => s.trim()).filter((s: string) => s.length > 0)
 			: [],
-		shell,
 		macos_prefs: macosPrefs
 	});
 };

src/routes/api/configs/alias/[alias]/+server.ts

@@ -27,7 +27,6 @@ export const GET: RequestHandler = async ({ platform, params }) => {
 
 	const tapsSet = new Set<string>();
 	const snapshotCasks = new Set<string>();
-	let shell: { oh_my_zsh: boolean; theme: string; plugins: string[] } | null = null;
 	let macosPrefs: { domain: string; key: string; type: string; value: string; desc: string }[] | null = null;
 
 	if (config.snapshot) {
@@ -39,13 +38,6 @@ export const GET: RequestHandler = async ({ platform, params }) => {
 			for (const cask of snapshot.packages?.casks || []) {
 				snapshotCasks.add(cask);
 			}
-			if (snapshot.shell) {
-				shell = {
-					oh_my_zsh: snapshot.shell.oh_my_zsh ?? false,
-					theme: snapshot.shell.theme ?? '',
-					plugins: snapshot.shell.plugins ?? []
-				};
-			}
 			if (Array.isArray(snapshot.macos_prefs) && snapshot.macos_prefs.length > 0) {
 				const filtered = snapshot.macos_prefs.filter(
 					(p: unknown): p is Record<string, unknown> =>
@@ -75,18 +67,18 @@ export const GET: RequestHandler = async ({ platform, params }) => {
 
 	for (const pkg of rawPackages) {
 		if (typeof pkg === 'string') {
-			packageNames.push(pkg);
 			if (snapshotCasks.has(pkg)) {
 				caskNames.push(pkg);
+			} else {
+				packageNames.push(pkg);
 			}
 		} else {
 			if (pkg.type === 'npm') {
 				npmNames.push(pkg.name);
+			} else if (pkg.type === 'cask') {
+				caskNames.push(pkg.name);
 			} else {
 				packageNames.push(pkg.name);
-				if (pkg.type === 'cask') {
-					caskNames.push(pkg.name);
-				}
 			}
 		}
 	}
@@ -113,7 +105,6 @@ export const GET: RequestHandler = async ({ platform, params }) => {
 		post_install: config.custom_script
 			? config.custom_script.split('\n').map((s: string) => s.trim()).filter((s: string) => s.length > 0)
 			: [],
-		shell,
 		macos_prefs: macosPrefs
 	});
 };