-
Notifications
You must be signed in to change notification settings - Fork 827
HTTP semantic convention stability migration for Pyramid #3982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
HTTP semantic convention stability migration for Pyramid #3982
Conversation
...opentelemetry-instrumentation-pyramid/src/opentelemetry/instrumentation/pyramid/callbacks.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, out of curiosity, why are the old histograms measured in milliseconds while the new histograms use seconds?
Thanks! Good question. The new semconv is definitely in seconds. The old histogram's milliseconds for this instrumentor were introduced a while ago (Aug 2022) and haven't changed since then -- I don't want to change it in this PR either. I'm guessing it predates either the semconv introduction of |
Description
Adds HTTP semantic convention stability migration / opt-in for
opentelemetry-instrumentation-pyramidFixes #3983
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Default span attributes
httpspan attributeshttp/duphas both sets.Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.