Skip to content

Faster spotless #15553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trask merged 1 commit into from
Dec 6, 2025
+19 −13
Merged

Faster spotless #15553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 8 additions & 13 deletions conventions/src/main/kotlin/otel.spotless-conventions.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,24 +85,19 @@ if (project == rootProject) {
".gitattributes",
".gitconfig",
".editorconfig",
"**/*.md",
"**/*.sh",
"**/*.dockerfile",
"**/gradle.properties"
Copy link
Member Author

@trask trask Dec 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the leading **/ causes slowness b/c searching entire directory tree

Copy link
Contributor

@laurit laurit Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are .md files in instrumentation too

"*.md",
"gradle.properties",
".github/**/*.md",
".github/**/*.sh",
"docs/**/*.md",
"examples/**/*.md",
"examples/**/gradle.properties",
"licenses/**/*.md"
)
leadingTabsToSpaces()
trimTrailingWhitespace()
endWithNewline()
}
groovy {
target("**/*.groovy")
targetExclude("**/build/**")
licenseHeaderFile(
rootProject.file("buildscripts/spotless.license.java"),
"(package|import|(?:abstract )?class)"
)
endWithNewline()
}
Comment on lines -97 to -105
Copy link
Member Author

@trask trask Dec 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only 1 module (grails) has groovy files so moved this there

predeclareDeps()
}

Expand Down
11 changes: 11 additions & 0 deletions instrumentation/grails-3.0/javaagent/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,17 @@ configurations.testRuntimeClasspath {
}
}

spotless {
groovy {
target("src/**/*.groovy")
licenseHeaderFile(
rootProject.file("buildscripts/spotless.license.java"),
"(package|import|(?:abstract )?class)"
)
endWithNewline()
}
}

tasks {
withType<Test>().configureEach {
systemProperty("testLatestDeps", latestDepTest)
Expand Down
Loading