From c39edee7b2dec6a7a1569f9eb82cb5efe340f8ec Mon Sep 17 00:00:00 2001 From: Rom Embedded Forth Date: Thu, 8 Jan 2026 12:15:16 -0800 Subject: [PATCH 1/2] Fix build failure of asm1130 on recent Gentoo (gcc version 14.2.1) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This failed to build with gcc version: gcc version 14.2.1 20241221 (Gentoo 14.2.1_p20241221 p7) with the following error: ---snip--- asm1130.c: In function ‘save_symbols’ asm1130.c:2132:9: error: implicit declaration of function ‘unlink’; did you mean ‘x_link’? [-Wimplicit-function-declaration] 2132 | unlink(SYSTEM_TABLE); | ^~~~~~ ---snip--- --- Ibm1130/utils/asm1130.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/Ibm1130/utils/asm1130.c b/Ibm1130/utils/asm1130.c index 03e806eac..9d20a0145 100644 --- a/Ibm1130/utils/asm1130.c +++ b/Ibm1130/utils/asm1130.c @@ -157,9 +157,7 @@ * Comment out this define to make @ and ' different in symbol names, keep to make equivalent */ -#if defined(VMS) # include /* to pick up 'unlink' */ -#endif #define BETWEEN(v,a,b) (((v) >= (a)) && ((v) <= (b))) #define MIN(a,b) (((a) <= (b)) ? (a) : (b)) From d28ac1475a2a65eacda1a4e12f8634e4dd83c4f3 Mon Sep 17 00:00:00 2001 From: Rom Embedded Forth Date: Sun, 18 Jan 2026 20:39:20 -0800 Subject: [PATCH 2/2] Address review comments (and Github CI breakage on windows builds) --- Ibm1130/utils/asm1130.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Ibm1130/utils/asm1130.c b/Ibm1130/utils/asm1130.c index 9d20a0145..8389d25bf 100644 --- a/Ibm1130/utils/asm1130.c +++ b/Ibm1130/utils/asm1130.c @@ -157,7 +157,9 @@ * Comment out this define to make @ and ' different in symbol names, keep to make equivalent */ +#if defined(__linux) || defined(VMS) # include /* to pick up 'unlink' */ +#endif #define BETWEEN(v,a,b) (((v) >= (a)) && ((v) <= (b))) #define MIN(a,b) (((a) <= (b)) ? (a) : (b))