Open
Conversation
apaolillo
requested changes
Mar 9, 2026
Collaborator
apaolillo
left a comment
apaolillo
left a comment
There was a problem hiding this comment.
Nice start, thanks for the meaningful addition! I left comments. I also think that adding a simple example to show how the uart works in benchkit would be helpful indeed.
| raise RuntimeError("Communication layer is not open.") | ||
| self._unchecked_close_comm() | ||
|
|
||
| def _unchecked_close_comm(self) -> None: |
| ignore_ret_codes: Iterable[int] = (), | ||
| ignore_any_error_code: bool = False, | ||
| ) -> str: | ||
| """Run a shell command on the target host. |
Collaborator
There was a problem hiding this comment.
that only works when use_shell=True?
apaolillo
reviewed
Mar 9, 2026
benchkit/communication/uart.py
Outdated
|
|
||
| def close_comm(self) -> None: | ||
| """ | ||
| Performs checks then, closes the communication layer. |
Collaborator
There was a problem hiding this comment.
when checks are you performing?
Signed-off-by: estak <esteban.aguililla.klein.pro@outlook.com>
Signed-off-by: estak <esteban.aguililla.klein.pro@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.