linking error

[mayman99]

Bug report

undefined reference to symbol 'pthread_rwlock_unlock@@GLIBC_2.2.5' cmake when building the package

Required information:

• Operating system and version:
  • Ubuntu 20.04
• OpenRMF installation type:
  • source
• OpenRMF version or commit hash
  • latest, 66cd1dc
• ROS distribution and version:
• ROS installation type:
  • binary
• Package or library, if applicable:
  • rmf_fleet_adapter

had to add -pthread to the target_link_libraries to be able to build

target_link_libraries(rmf_visualization_schedule
  PUBLIC
    -pthread
    rmf_traffic_ros2::rmf_traffic_ros2
    rmf_traffic::rmf_traffic
    ${rclcpp_LIBRARIES}
    ${websocketpp_LIBRARIES}
    OpenSSL::SSL
    OpenSSL::Crypto
    ${rmf_traffic_msgs_LIBRARIES}
)

Steps to reproduce the bug

Expected behavior

Actual behavior

Screenshots

Additional information

[aaronchongth]

Per DM, it might be due to the older version of gcc, I have not been able to reproduce this linking error with my gcc version,

gcc (Ubuntu 9.3.0-17ubuntu1~20.04) 9.3.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

[mayman99]

I've upgraded my gcc version but the issue still stand
exact output is

--- stderr: rmf_visualization_schedule                                                                                    
/usr/bin/ld: CMakeFiles/schedule_visualizer.dir/src/main.cpp.o: undefined reference to symbol 'pthread_rwlock_unlock@@GLIBC_2.2.5'
/usr/bin/ld: /lib/x86_64-linux-gnu/libpthread.so.0: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
make[2]: *** [CMakeFiles/schedule_visualizer.dir/build.make:923: schedule_visualizer] Error 1
make[1]: *** [CMakeFiles/Makefile2:100: CMakeFiles/schedule_visualizer.dir/all] Error 2
make: *** [Makefile:141: all] Error 2

[aaronchongth]

@mayman99 Just checking in again, after a fresh install of Ubuntu 20.04, is this issue still present?

[Yadunund]

Linking issue should be fixed in #44