From cb1b8534dfbacba0698afabb0f289d147e54f0da Mon Sep 17 00:00:00 2001
From: Rian Stockbower <rstockbower@gmail.com>
Date: Sat, 7 Feb 2026 14:42:56 -0500
Subject: [PATCH] feat(chocolatey): simplify packaging per reviewer feedback

Remove unnecessary .ignore file creation (Chocolatey only shims .exe
files) and remove custom uninstall script (Chocolatey handles zip
package cleanup natively).

Closes #109
---
 .github/workflows/test-chocolatey.yml             |  4 ----
 packaging/chocolatey/tools/chocolateyInstall.ps1  |  5 -----
 .../chocolatey/tools/chocolateyUninstall.ps1      | 15 ---------------
 3 files changed, 24 deletions(-)
 delete mode 100644 packaging/chocolatey/tools/chocolateyUninstall.ps1

diff --git a/.github/workflows/test-chocolatey.yml b/.github/workflows/test-chocolatey.yml
index 0e12e82..ddf2817 100644
--- a/.github/workflows/test-chocolatey.yml
+++ b/.github/workflows/test-chocolatey.yml
@@ -42,10 +42,6 @@ jobs:
 
           # Binary is already in tools/ from CI build
           Write-Host "slack-chat-cli installed from local build for testing"
-
-          # Exclude non-executables from shimming
-          New-Item "$toolsDir\LICENSE.ignore" -Type File -Force | Out-Null
-          New-Item "$toolsDir\README.md.ignore" -Type File -Force | Out-Null
           '@ | Set-Content tools/chocolateyInstall.ps1
 
       - name: Pack Chocolatey package
diff --git a/packaging/chocolatey/tools/chocolateyInstall.ps1 b/packaging/chocolatey/tools/chocolateyInstall.ps1
index c7a2faf..f606abb 100644
--- a/packaging/chocolatey/tools/chocolateyInstall.ps1
+++ b/packaging/chocolatey/tools/chocolateyInstall.ps1
@@ -32,9 +32,4 @@ Install-ChocolateyZipPackage -PackageName $env:ChocolateyPackageName `
     -Checksum $checksum `
     -ChecksumType 'sha256'
 
-# Exclude non-executables from shimming
-# Chocolatey auto-creates shims for .exe files; .ignore files prevent shimming other files
-New-Item "$toolsDir\LICENSE.ignore" -Type File -Force | Out-Null
-New-Item "$toolsDir\README.md.ignore" -Type File -Force | Out-Null
-
 Write-Host "slck installed successfully. Run 'slck --help' to get started."
diff --git a/packaging/chocolatey/tools/chocolateyUninstall.ps1 b/packaging/chocolatey/tools/chocolateyUninstall.ps1
deleted file mode 100644
index da7de4e..0000000
--- a/packaging/chocolatey/tools/chocolateyUninstall.ps1
+++ /dev/null
@@ -1,15 +0,0 @@
-$ErrorActionPreference = 'Stop'
-
-$toolsDir = Split-Path -Parent $MyInvocation.MyCommand.Definition
-
-Write-Host "Uninstalling slck..."
-
-# Remove extracted files
-Remove-Item "$toolsDir\slck.exe" -Force -ErrorAction SilentlyContinue
-Remove-Item "$toolsDir\LICENSE" -Force -ErrorAction SilentlyContinue
-Remove-Item "$toolsDir\README.md" -Force -ErrorAction SilentlyContinue
-
-# Remove .ignore files created during install
-Remove-Item "$toolsDir\*.ignore" -Force -ErrorAction SilentlyContinue
-
-Write-Host "slck has been uninstalled."