Skip to content

Commit aa07139

Browse files
committed
feat(chocolatey): simplify packaging per reviewer feedback
Remove unnecessary .ignore file creation (Chocolatey only shims .exe files) and remove custom uninstall script (Chocolatey handles zip package cleanup natively). Closes #36
1 parent 6f371ea commit aa07139

3 files changed

Lines changed: 0 additions & 24 deletions

File tree

.github/workflows/test-chocolatey.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,6 @@ jobs:
4242
4343
# Binary is already in tools/ from CI build
4444
Write-Host "salesforce-cli installed from local build for testing"
45-
46-
# Exclude non-executables from shimming
47-
New-Item "$toolsDir\LICENSE.ignore" -Type File -Force | Out-Null
48-
New-Item "$toolsDir\README.md.ignore" -Type File -Force | Out-Null
4945
'@ | Set-Content tools/chocolateyInstall.ps1
5046
5147
- name: Pack Chocolatey package

packaging/chocolatey/tools/chocolateyInstall.ps1

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,4 @@ Install-ChocolateyZipPackage -PackageName $env:ChocolateyPackageName `
3232
-Checksum $checksum `
3333
-ChecksumType 'sha256'
3434

35-
# Exclude non-executables from shimming
36-
# Chocolatey auto-creates shims for .exe files; .ignore files prevent shimming other files
37-
New-Item "$toolsDir\LICENSE.ignore" -Type File -Force | Out-Null
38-
New-Item "$toolsDir\README.md.ignore" -Type File -Force | Out-Null
39-
4035
Write-Host "salesforce-cli installed successfully. Run 'sfdc --help' to get started."

packaging/chocolatey/tools/chocolateyUninstall.ps1

Lines changed: 0 additions & 15 deletions
This file was deleted.

0 commit comments

Comments
 (0)