Skip to content

Commit cffe7dc

Browse files
authored
feat(chocolatey): simplify packaging per reviewer feedback (#79)
## Summary - Remove unnecessary `.ignore` file creation (Chocolatey only shims `.exe` files) - Remove custom uninstall script (Chocolatey handles zip package cleanup natively via `Install-ChocolateyZipPackage`) - Update test-chocolatey.yml to match Per Chocolatey reviewer feedback from flcdrg (David). Closes #78
1 parent 583cc96 commit cffe7dc

3 files changed

Lines changed: 0 additions & 19 deletions

File tree

.github/workflows/test-chocolatey.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,6 @@ jobs:
4242
4343
# Binary is already in tools/ from CI build
4444
Write-Host "newrelic-cli installed from local build for testing"
45-
46-
# Exclude non-executables from shimming
47-
New-Item "$toolsDir\LICENSE.ignore" -Type File -Force | Out-Null
48-
New-Item "$toolsDir\README.md.ignore" -Type File -Force | Out-Null
4945
'@ | Set-Content tools/chocolateyInstall.ps1
5046
5147
- name: Pack Chocolatey package

packaging/chocolatey/tools/chocolateyInstall.ps1

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,4 @@ Install-ChocolateyZipPackage -PackageName $env:ChocolateyPackageName `
3232
-Checksum $checksum `
3333
-ChecksumType 'sha256'
3434

35-
# Exclude non-executables from shimming
36-
New-Item "$toolsDir\LICENSE.ignore" -Type File -Force | Out-Null
37-
New-Item "$toolsDir\README.md.ignore" -Type File -Force | Out-Null
38-
3935
Write-Host "nrq installed successfully. Run 'nrq --help' to get started."

packaging/chocolatey/tools/chocolateyUninstall.ps1

Lines changed: 0 additions & 11 deletions
This file was deleted.

0 commit comments

Comments
 (0)