From 03e5febd00cce0e10c1c384801f39cec1e20c4f3 Mon Sep 17 00:00:00 2001 From: Rian Stockbower Date: Sat, 7 Feb 2026 14:42:14 -0500 Subject: [PATCH] feat(chocolatey): simplify packaging per reviewer feedback Remove unnecessary .ignore file creation (Chocolatey only shims .exe files) and remove custom uninstall script (Chocolatey handles zip package cleanup natively). Closes #47 --- packaging/chocolatey/tools/chocolateyInstall.ps1 | 5 ----- .../chocolatey/tools/chocolateyUninstall.ps1 | 15 --------------- 2 files changed, 20 deletions(-) delete mode 100644 packaging/chocolatey/tools/chocolateyUninstall.ps1 diff --git a/packaging/chocolatey/tools/chocolateyInstall.ps1 b/packaging/chocolatey/tools/chocolateyInstall.ps1 index 1a887de..05fcd7e 100644 --- a/packaging/chocolatey/tools/chocolateyInstall.ps1 +++ b/packaging/chocolatey/tools/chocolateyInstall.ps1 @@ -32,9 +32,4 @@ Install-ChocolateyZipPackage -PackageName $env:ChocolateyPackageName ` -Checksum $checksum ` -ChecksumType 'sha256' -# Exclude non-executables from shimming -# Chocolatey auto-creates shims for .exe files; .ignore files prevent shimming other files -New-Item "$toolsDir\LICENSE.ignore" -Type File -Force | Out-Null -New-Item "$toolsDir\README.md.ignore" -Type File -Force | Out-Null - Write-Host "hubspot-cli installed successfully. Run 'hspt --help' to get started." diff --git a/packaging/chocolatey/tools/chocolateyUninstall.ps1 b/packaging/chocolatey/tools/chocolateyUninstall.ps1 deleted file mode 100644 index 0057c3b..0000000 --- a/packaging/chocolatey/tools/chocolateyUninstall.ps1 +++ /dev/null @@ -1,15 +0,0 @@ -$ErrorActionPreference = 'Stop' - -$toolsDir = Split-Path -Parent $MyInvocation.MyCommand.Definition - -Write-Host "Uninstalling hspt..." - -# Remove extracted files -Remove-Item "$toolsDir\hspt.exe" -Force -ErrorAction SilentlyContinue -Remove-Item "$toolsDir\LICENSE" -Force -ErrorAction SilentlyContinue -Remove-Item "$toolsDir\README.md" -Force -ErrorAction SilentlyContinue - -# Remove .ignore files created during install -Remove-Item "$toolsDir\*.ignore" -Force -ErrorAction SilentlyContinue - -Write-Host "hspt has been uninstalled."