[Crash] Unchecked user.loadout.primaryId.length in getUserData

[coderabbitai]

Summary

Services server crashes when user.loadout.primaryId is undefined during account data processing.

Affected Code

server-services/src/data_management/accountManagement.js:99

user.loadout = JSON.parse(user.loadout);
for (var i = 0; i < user.loadout.primaryId.length; i++) {
  // CRASH if user.loadout.primaryId is undefined

Vulnerability

If database contains corrupted loadout JSON or schema mismatch.

Impact

• Services server crash on user data fetch
• Denial of service for authentication

Proof of Concept

Corrupt user loadout in DB to missing primaryId field.

Recommended Fix

for (var i = 0; i < (user.loadout?.primaryId?.length || 0); i++) {

References

• PR: New Blocks & Ported fancyMuzzle flash #43