From 0a51d1a76e5aab9710a3970a1ae46e105170255d Mon Sep 17 00:00:00 2001 From: David Porter Date: Thu, 22 Jan 2026 15:43:16 +1100 Subject: [PATCH 1/3] AP-6813 # remove monitor from sync options --- CHANGELOG.md | 1 + src/cdn/commands/deploy.ts | 12 ++---------- 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index ef5ef9f..19bf002 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - **[BREAKING]** API Hosting runtime version from Node.js 18 to [Node.js 24](https://nodejs.org/en/blog/release/v24.11.0) - Require minimum [Node.js 24](https://nodejs.org/en/blog/release/v24.11.0) +- moved transfer monitor from s3 sync ### Removed diff --git a/src/cdn/commands/deploy.ts b/src/cdn/commands/deploy.ts index 0499aca..cfda08f 100644 --- a/src/cdn/commands/deploy.ts +++ b/src/cdn/commands/deploy.ts @@ -6,7 +6,7 @@ import { PutObjectCommandInput, S3Client, } from '@aws-sdk/client-s3' -import { S3SyncClient, TransferMonitor, TransferStatus } from 's3-sync-client' +import { S3SyncClient } from 's3-sync-client' import mime from 'mime-types' import confirm from '../utils/confirm.js' @@ -51,19 +51,10 @@ export default async function ( const { sync } = new S3SyncClient({ client: s3Client }) - const monitor = new TransferMonitor() - monitor.on('progress', (transferStatus: TransferStatus) => { - progress = Math.floor( - (transferStatus.size.current / transferStatus.size.total) * 100, - ) - spinner.text = `Uploading to CDN: ${progress}%` - }) - // Allow deployment of files in a sub directory to the current working directory const cwd = path.join(flags.cwd, input[0] || '.') const options: SyncLocalWithBucketOptions = { del: flags.prune, - monitor, commandInput: (input) => { const putObjectCommandInput: Partial = { ContentType: @@ -73,6 +64,7 @@ export default async function ( return putObjectCommandInput as unknown as GetObjectCommandInput }, } + await sync(cwd, `s3://${cfg.scope}/${flags.env}`, options) spinner.succeed('Upload(s) complete!') } catch (error) { From 221a561bf12d16824715a75e0f4bb21714ee20e2 Mon Sep 17 00:00:00 2001 From: David Porter Date: Fri, 23 Jan 2026 10:37:33 +1100 Subject: [PATCH 2/3] AP-6813 # remove progress variable --- src/cdn/commands/deploy.ts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/cdn/commands/deploy.ts b/src/cdn/commands/deploy.ts index cfda08f..7b1ade5 100644 --- a/src/cdn/commands/deploy.ts +++ b/src/cdn/commands/deploy.ts @@ -37,8 +37,6 @@ export default async function ( const spinner = ora({ spinner: 'dots', text: 'Uploading to CDN' }) spinner.start() - let progress = 0 - try { const s3Client = new S3Client({ region: tenant.region, @@ -68,7 +66,7 @@ export default async function ( await sync(cwd, `s3://${cfg.scope}/${flags.env}`, options) spinner.succeed('Upload(s) complete!') } catch (error) { - spinner.fail(`Upload(s) failed: ${progress}%`) + spinner.fail(`Upload(s) failed`) throw error } From d029acd6e2768cd920764d0c7650c1ba5eaa861a Mon Sep 17 00:00:00 2001 From: David Porter Date: Fri, 23 Jan 2026 15:16:55 +1100 Subject: [PATCH 3/3] AP-6813 # fix changelog --- CHANGELOG.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 19bf002..6b362d4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,7 +15,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - **[BREAKING]** API Hosting runtime version from Node.js 18 to [Node.js 24](https://nodejs.org/en/blog/release/v24.11.0) - Require minimum [Node.js 24](https://nodejs.org/en/blog/release/v24.11.0) -- moved transfer monitor from s3 sync + +### Removed +- transfer monitor from s3 sync ### Removed