Hi,
I've fixed some of your I2C related code but got the challenge that I don't own a SPI-ready display, so I can't check if my code also works on those. Could you please check if you can remove all explicit casts to short and migrate all constants to int?
This creates some trouble when shifting the int to bytes afterwards (int &= (0xFF)) in the i2cWrite-Method and I don't see a reason why those short's are really necessary.
When migrating from short to int is fine for you, I will create a pull-request and provide a working I2C example also.
Would you like to have a maven-ready build and upload that library to maven-central?
Looking forward to your response and thanks for your awesome work - you saved me a lot of time. I'll be happy to share and contribute. 👍
Kind regards and have a happy new year!
Hi,
I've fixed some of your I2C related code but got the challenge that I don't own a SPI-ready display, so I can't check if my code also works on those. Could you please check if you can remove all explicit casts to short and migrate all constants to int?
This creates some trouble when shifting the int to bytes afterwards (int &= (0xFF)) in the i2cWrite-Method and I don't see a reason why those short's are really necessary.
When migrating from short to int is fine for you, I will create a pull-request and provide a working I2C example also.
Would you like to have a maven-ready build and upload that library to maven-central?
Looking forward to your response and thanks for your awesome work - you saved me a lot of time. I'll be happy to share and contribute. 👍
Kind regards and have a happy new year!