Skip to content

Commit 544591b

Browse files
authored
Merge branch 'supabase:main' into main
2 parents 5b9bc88 + dc817c0 commit 544591b

59 files changed

Lines changed: 930 additions & 209 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/workflows/ci.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ jobs:
4141
cargo-fmt:
4242
if: github.event.pull_request.draft == false
4343
name: 'fmt'
44-
runs-on: ubuntu-latest
44+
runs-on: blacksmith-4vcpu-ubuntu-2404
4545
steps:
4646
- uses: actions/checkout@v4
4747
- uses: denoland/setup-deno@v2
@@ -53,7 +53,7 @@ jobs:
5353
cargo-clippy:
5454
if: github.event.pull_request.draft == false
5555
name: 'cargo clippy'
56-
runs-on: ubuntu-latest
56+
runs-on: blacksmith-4vcpu-ubuntu-2404
5757
steps:
5858
- uses: actions/checkout@v4
5959
- name: Install deps
@@ -67,7 +67,7 @@ jobs:
6767
cargo-test:
6868
if: github.event.pull_request.draft == false
6969
name: 'cargo test'
70-
runs-on: ubuntu-latest
70+
runs-on: blacksmith-4vcpu-ubuntu-2404
7171
steps:
7272
- name: Install deps
7373
run: |

.github/workflows/mirror.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ permissions:
1313

1414
jobs:
1515
mirror:
16-
runs-on: ubuntu-latest
16+
runs-on: blacksmith-4vcpu-ubuntu-2404
1717
permissions:
1818
contents: read
1919
packages: write

.github/workflows/release.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ permissions:
1212

1313
jobs:
1414
release:
15-
runs-on: ubuntu-latest
15+
runs-on: blacksmith-4vcpu-ubuntu-2404
1616
outputs:
1717
published: ${{ steps.semantic.outputs.new_release_published }}
1818
version: ${{ steps.semantic.outputs.new_release_version }}
@@ -37,7 +37,7 @@ jobs:
3737
needs:
3838
- release
3939
if: needs.release.outputs.published == 'true'
40-
runs-on: ubuntu-latest
40+
runs-on: blacksmith-4vcpu-ubuntu-2404
4141
env:
4242
arch: amd64
4343
outputs:
@@ -124,7 +124,7 @@ jobs:
124124
125125
merge_manifest:
126126
needs: [release, publish_x86, publish_arm]
127-
runs-on: ubuntu-latest
127+
runs-on: blacksmith-4vcpu-ubuntu-2404
128128
permissions:
129129
contents: read
130130
packages: write

Cargo.lock

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

DEVELOPERS.md

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -40,18 +40,6 @@ docker build -t supabase/edge-runtime .
4040
docker run -it --rm -p 9000:9000 -v ./examples/:/examples supabase/edge-runtime start --main-service /examples/main
4141
```
4242

43-
Another option would be to install [Orb](https://docs.orbstack.dev/install) and
44-
use an [Orbstack Machine](https://docs.orbstack.dev/machines/) to run a Linux
45-
Machine.
46-
47-
First create a machine:
48-
49-
```
50-
orb create ubuntu new-ubuntu
51-
```
52-
53-
and run `orb` in the base directory to enter the virtual machine.
54-
5543
## How to run tests
5644

5745
```sh

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ We welcome contributions to Supabase Edge Runtime!
4242

4343
To get started either open an issue on
4444
[GitHub](https://github.com/supabase/edge-runtime/issues) or drop us a message
45-
on [Discord](https://discord.com/invite/R7bSpeBSJE)
45+
on [Discord](https://discord.supabase.com)
4646

4747
Edge Runtime follows Supabase's
4848
[Code of Conduct](https://github.com/supabase/.github/blob/main/CODE_OF_CONDUCT.md).

cli/src/env.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,6 @@ pub(super) fn resolve_deno_runtime_env() {
3333
})
3434
};
3535

36-
runtime::MAYBE_DENO_VERSION.get_or_init(|| deno::version().to_string());
37-
3836
resolve_boolish_env(
3937
"DENO_NO_DEPRECATION_WARNINGS",
4038
&runtime::SHOULD_DISABLE_DEPRECATED_API_WARNING,

cli/src/flags.rs

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,15 @@ fn get_start_command() -> Command {
208208
.value_parser(value_parser!(u64)),
209209
)
210210
.arg(
211-
arg!(--"request-idle-timeout" <MILLISECONDS>)
211+
arg!(--"main-worker-request-idle-timeout" <MILLISECONDS>)
212+
.help(concat!(
213+
"Maximum time in milliseconds that can be waited from when a ",
214+
"worker takes over the request (disabled by default)"
215+
))
216+
.value_parser(value_parser!(u64)),
217+
)
218+
.arg(
219+
arg!(--"user-worker-request-idle-timeout" <MILLISECONDS>)
212220
.help(concat!(
213221
"Maximum time in milliseconds that can be waited from when a ",
214222
"worker takes over the request (disabled by default)"

cli/src/main.rs

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ use anyhow::Context;
1313
use anyhow::Error;
1414
use base::server;
1515
use base::server::Builder;
16+
use base::server::RequestIdleTimeout;
1617
use base::server::ServerFlags;
1718
use base::server::Tls;
1819
use base::utils::units::percentage_value;
@@ -180,8 +181,12 @@ fn main() -> Result<ExitCode, anyhow::Error> {
180181
sub_matches.get_one::<usize>("max-parallelism").cloned();
181182
let maybe_request_wait_timeout =
182183
sub_matches.get_one::<u64>("request-wait-timeout").cloned();
183-
let maybe_request_idle_timeout =
184-
sub_matches.get_one::<u64>("request-idle-timeout").cloned();
184+
let maybe_main_worker_request_idle_timeout = sub_matches
185+
.get_one::<u64>("main-worker-request-idle-timeout")
186+
.cloned();
187+
let maybe_user_worker_request_idle_timeout = sub_matches
188+
.get_one::<u64>("user-worker-request-idle-timeout")
189+
.cloned();
185190
let maybe_request_read_timeout =
186191
sub_matches.get_one::<u64>("request-read-timeout").cloned();
187192

@@ -249,7 +254,10 @@ fn main() -> Result<ExitCode, anyhow::Error> {
249254
graceful_exit_keepalive_deadline_ms,
250255
event_worker_exit_deadline_sec,
251256
request_wait_timeout_ms: maybe_request_wait_timeout,
252-
request_idle_timeout_ms: maybe_request_idle_timeout,
257+
request_idle_timeout: RequestIdleTimeout::from_millis(
258+
maybe_main_worker_request_idle_timeout,
259+
maybe_user_worker_request_idle_timeout,
260+
),
253261
request_read_timeout_ms: maybe_request_read_timeout,
254262
request_buffer_size: Some(request_buffer_size),
255263

@@ -272,7 +280,7 @@ fn main() -> Result<ExitCode, anyhow::Error> {
272280
"{}",
273281
concat!(
274282
"if `oneshot` policy is enabled, the maximum ",
275-
"parallelism is fixed to `1` as forcibly"
283+
"parallelism is fixed to `1` as forcibly ^^"
276284
)
277285
);
278286
}

crates/base/Cargo.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,7 @@ tokio-util = { workspace = true, features = ["rt", "compat"] }
8787
tracing-subscriber = { workspace = true, features = ["env-filter", "tracing-log"] }
8888

8989
async-tungstenite = { version = "0.25.0", default-features = false }
90+
diff = "0.1"
9091
tungstenite = { version = "0.21.0", default-features = false, features = ["handshake"] }
9192

9293
[build-dependencies]

0 commit comments

Comments
 (0)