Add omero-zarr-pixel-buffer#6450
Open
dominikl wants to merge 2 commits into
Open
Conversation
Member
|
👍 Would be great to have this installed in OMERO by default! |
Member
Author
|
Re build failure, can't find omero-zarr-pixel-buffer. |
dominikl
force-pushed
the
ozpb
branch
2 times, most recently
from
23f82b2 to
c36e29d
Compare
|
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: https://forum.image.sc/t/trying-to-import-a-zarr-from-s3-to-omero-5-16-8/121036/3 |
dominikl
force-pushed
the
ozpb
branch
5 times, most recently
from
5025e50 to
20ec9ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd strongly suggest to add the omero-zarr-pixel-buffer to the omero.server build. Like mentioned in https://github.com/glencoesoftware/omero-zarr-pixel-buffer?tab=readme-ov-file#installation .
The current version 0.6.1 only has 5 additional dependencies. But with Zarr v3 support and move to AWS SDK v2 (ome/omero-zarr-pixel-buffer#13 ) there will be 61 (mostly because AWS SDK v2 is highly modularised in contrast to v1). It would also make it much easier to test in CI.
/cc @jburel