[ADD] sale_discount: Added the recomputation logic of global discount #1044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hapat-odoo
commented
Dec 3, 2025
hapat-odoo
commented
- Updated sale order methods to recalculate discount on all line updates.
- Removed discount line when order becomes empty.
- Enforced single global discount line handling.
…scount - Updated sale order methods to recalculate discount on all line updates. - Removed discount line when order becomes empty. - Enforced single global discount line handling.
|
|
bit-odoo
reviewed
Dec 3, 2025
bit-odoo
left a comment
bit-odoo
left a comment
There was a problem hiding this comment.
Hello,
can you please update your commit message tiltle and add task id in end of commit message.
bit-odoo
reviewed
Dec 4, 2025
| subtotal += line.price_subtotal | ||
|
|
||
| for discount_line in discount_lines: | ||
| match = re.search(r"(\d+(?:\.\d+)?)%", discount_line.name) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.