[ADD] pos_order_salesperson: add salesperson selection in POS #1042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
danal-odoo
changed the title
danal-odoo
force-pushed
the
19.0-pos_order_salesperson-danal
branch
from
9402236 to
3063b1b
Compare
bit-odoo
reviewed
Dec 4, 2025
There was a problem hiding this comment.
Hello,
I have made some comments.
Can you please write your commit and pr message, header according to this guideline https://www.odoo.com/documentation/19.0/contributing/development/git_guidelines.html
|
|
||
|
|
||
| class PosOrder(models.Model): | ||
| _inherit = ["pos.order"] |
There was a problem hiding this comment.
Suggested change
| _inherit = ["pos.order"] | |
| _inherit = 'pos.order' |
|
|
||
| class PosOrder(models.Model): | ||
| _inherit = ["pos.order"] | ||
| _name = 'pos.order' |
|
|
||
|
|
||
| class PosSession(models.Model): | ||
| _inherit = "pos.session" |
There was a problem hiding this comment.
Suggested change
| _inherit = "pos.session" | |
| _inherit = 'pos.session' |
| @@ -0,0 +1,46 @@ | |||
| import { _t } from "@web/core/l10n/translation"; | |||
| "data": [ | ||
| "views/pos_order_view.xml", | ||
| ], | ||
| "assets": {"point_of_sale._assets_pos": ["pos_order_salesperson/static/src/**/*"]}, |
There was a problem hiding this comment.
Suggested change
| "assets": {"point_of_sale._assets_pos": ["pos_order_salesperson/static/src/**/*"]}, | |
| "assets": { | |
| "point_of_sale._assets_pos": [ | |
| "pos_order_salesperson/static/src/**/*" | |
| ] | |
| }, |
danal-odoo
force-pushed
the
19.0-pos_order_salesperson-danal
branch
from
3063b1b to
e48a96c
Compare
bit-odoo
reviewed
Dec 4, 2025
bit-odoo
left a comment
bit-odoo
left a comment
There was a problem hiding this comment.
Hello,
Before pushing anything check your diff properly.
danal-odoo
force-pushed
the
19.0-pos_order_salesperson-danal
branch
3 times, most recently
from
3d4bec1 to
a2b2742
Compare
danal-odoo
changed the title
|
Hello, Do not push your code in a rush. First check that you have adapted all changes, then you can push your. |
Author
|
i have resolved all suggested mistakes in code and pushed. |
|
Can you please mention the task ID in the commit and pr message? |
Before, POS orders were linked to the user logged into
the session or the active cashier.
There was no functionality to assign a specific salesperson to the
transaction.
This limitation made it difficult to calculate commissions or audit
sales performance by employee, particularly in scenarios where the
person operating the register is different from the person who
advised the customer.
This adds the ability to select a specific salesperson directly
from the Point of Sale interface. This selection is stored on the
order and is visible in the backend views.
Technical details:
- Model (`pos.order`): Added `salesperson_id` field to store the
selected employee on the order record.
- Session (`pos_session`): Inherited to load `hr.employee` data into
the frontend context upon initialization.
- UI Components:
- Added `SalespersonList` and `SalespersonLine` to display
available employees in a selection modal.
- Added a 'Salesperson' button to the `ControlButtons` area of
the `ProductScreen`.
- Views: Added `salesperson_id` to the `pos.order` form and list
views to ensure the data is visible in the backend.
task-4680845
danal-odoo
force-pushed
the
19.0-pos_order_salesperson-danal
branch
from
a2b2742 to
288e2e0
Compare
Author
|
i have updated commit and pr message as per odoo guidelines |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, POS orders were linked to the user logged into
the session or the active cashier.
There was no functionality to assign a specific salesperson to the
transaction.
This limitation made it difficult to calculate commissions or audit
sales performance by employee, particularly in scenarios where the
person operating the register is different from the person who
advised the customer.
This adds the ability to select a specific salesperson directly
from the Point of Sale interface. This selection is stored on the
order and is visible in the backend views.
Technical details:
pos.order): Addedsalesperson_idfield to store theselected employee on the order record.
pos_session): Inherited to loadhr.employeedata intothe frontend context upon initialization.
SalespersonListandSalespersonLineto displayavailable employees in a selection modal.
ControlButtonsarea ofthe
ProductScreen.salesperson_idto thepos.orderform and listviews to ensure the data is visible in the backend.
task-4680845