[IMP] estate: Refine model fields and view structure

- Clean whitespace and improve formatting across model files.
- Enhance state management logic in estate_property.
- Remove unused buttons and fields to simplify property views.
- Update selection fields for improved readability and maintainability.

Author: hapat-odoo

Estate/models/estate_property.py

@@ -7,7 +7,7 @@
 class EstateProperty(models.Model):
     _name = "estate.property"
     _description = "Real Estate Property"
-    _order = "id desc"
+    _order = "id desc "
     name = fields.Char(required=True)
     description = fields.Text()
     postcode = fields.Char()
@@ -20,9 +20,27 @@ class EstateProperty(models.Model):
     garage = fields.Boolean()
     garden = fields.Boolean()
     garden_area = fields.Integer()
-    garden_orientation = fields.Selection([("north", "North"),("south", "South"),("east", "East"),("west", "West"),])
+    garden_orientation = fields.Selection(
+        [
+            ("north", "North"),
+            ("south", "South"),
+            ("east", "East"),
+            ("west", "West"),
+        ]
+    )
     active = fields.Boolean(default=True)
-    state = fields.Selection([("new", "New"),("offer_received", "Offer Received"),("offer_accepted", "Offer Accepted"),("sold", "Sold"),("canceled", "Canceled")], required=True, copy=False , )
+    state = fields.Selection(
+        [
+            ("new", "New"),
+            ("offer_received", "Offer Received"),
+            ("offer_accepted", "Offer Accepted"),
+            ("sold", "Sold"),
+            ("canceled", "Canceled"),
+        ],
+        required=True,
+        copy=False,
+        default="new"
+    )
     property_type_id = fields.Many2one("estate.property.type", string="Property Type")
     buyer_id = fields.Many2one("res.partner", string="Buyer")
     salesperson_id = fields.Many2one("res.users", string="Salesperson")
@@ -31,20 +49,19 @@ class EstateProperty(models.Model):
     total_area = fields.Float(compute="_compute_total_area", string="Total Area", store=True)
     best_price = fields.Float(compute="_compute_best_price", string="Best Offer", store=True)
     validity_days = fields.Integer(default=7)
-    date_deadline = fields.Date(compute="_compute_date_deadline",inverse="_inverse_date_deadline",store=True,)
-    property_type_id = fields.Many2one("estate.property.type", string="Property Type")
-
+    date_deadline = fields.Date(compute="_compute_date_deadline", inverse="_inverse_date_deadline", store=True)
+    
     _check_price = models.Constraint(
         'CHECK(expected_price > 0 AND selling_price >= 0)',
-        'The expected price of a property must be strictly positive.'
+        'The Price of a property must be strictly positive.',
     )
-
+    
     @api.depends("living_area", "garden_area")
     def _compute_total_area(self):
         for record in self:
             record.total_area = (record.living_area or 0) + (record.garden_area or 0)
 
-    @api.depends("offer_ids.price")
+    @api.depends("offer_ids.price" , "state")
     def _compute_best_price(self):
         for record in self:
             record.best_price = max(record.offer_ids.mapped("price")) if record.offer_ids else 0.0
@@ -74,7 +91,16 @@ def _onchange_garden(self):
             else:
                 record.garden_area = 0
                 record.garden_orientation = False
-
+    
+    def write(self, vals):
+        if 'offer_ids' in vals:
+            result = super().write(vals)
+            for record in self:
+                if record.offer_ids and record.state == 'new':
+                    record.state = 'offer_received'
+            return result
+        return super().write(vals)
+    
     def action_set_sold(self):
         for record in self:
             record.state = "sold"
@@ -83,15 +109,6 @@ def action_set_canceled(self):
         for record in self:
             record.state = "canceled"
 
-    def action_set_next_status(self):
-        for record in self:
-            if record.state == "new":
-                record.state = "offer_received"
-            elif record.state == "offer_received":
-                record.state = "offer_accepted"
-            elif record.state == "offer_accepted":
-                record.state = "sold"
-
     def action_back_to_new(self):
         for record in self:
             record.state = "new"

Estate/models/estate_property_offer.py

@@ -6,22 +6,21 @@ class EstatePropertyOffer(models.Model):
     _name = "estate.property.offer"
     _description = "Real Estate Property Offer"
     _order = "price desc"
+
     price = fields.Float(required=True)
     status = fields.Selection(
         [
-            ('pending', 'Pending'),
             ('accepted', 'Accepted'),
             ('refused', 'Refused'),
         ],
     )
-
     property_id = fields.Many2one("estate.property", string="Property", required=True)
     partner_id = fields.Many2one("res.partner", string="Buyer", required=True)
 
     def action_accept_offer(self):
         for record in self:
             record.status = 'accepted'
-
+                
     def action_refuse_offer(self):
         for record in self:
             record.status = 'refused'

Estate/models/estate_property_tag.py

@@ -4,7 +4,7 @@
 class EstatePropertyTag(models.Model):
     _name = "estate.property.tag"
     _description = "Real Estate Property Tag"
-    _order = "name desc"
-    color = fields.Integer( string='Color Index', default=3)
+    _order = "name desc "
+    color = fields.Integer(string='Color Index', default=3)
 
     name = fields.Char(required=True)

Estate/models/estate_property_type.py

@@ -5,24 +5,26 @@
 class EstatePropertyType(models.Model):
     _name = "estate.property.type"
     _description = "Real Estate Property Type"
-    _order="name desc"
+    _order="name desc "
 
     name = fields.Char(required=True)
     property_ids = fields.One2many("estate.property", "property_type_id", string="Properties")
     sequence = fields.Integer('Sequence', default=7)
-    offer_count = fields.Integer(string="Number of Offers",compute="_compute_offer_count")
+    offer_count = fields.Integer(string="Number of Offers", compute="_compute_offer_count")
 
     _check_type_name_unique_ratio = models.Constraint(
         'CHECK(name)',
         'The property name must be unique.'
     )
+
     @api.depends('property_ids.offer_ids')
     def _compute_offer_count(self):
         for property_type in self:
             offer_count = 0
             for property in property_type.property_ids:
                 offer_count += len(property.offer_ids)
             property_type.offer_count = offer_count
+            
     @api.constrains('name')
     def _check_type_name_unique(self):
         for record in self:

Estate/views/estate_property_offer_views.xml

@@ -31,4 +31,4 @@
             </form>
         </field>
     </record>
-</odoo>
+</odoo>

Estate/views/estate_property_views.xml

@@ -28,7 +28,6 @@
     <field name="arch" type="xml">
         <form string="Property">
             <header>
-                <button name="action_set_next_status" string="Next" type="object"/>
                 <button name="action_back_to_new" string="Reset to New" type="object"/>
                 <button name="action_set_sold" string="Mark as Sold" type="object"/>
                 <button name="action_set_canceled" string="Cancel" type="object"/>
@@ -41,7 +40,6 @@
                 <group>
                     <group string="Property Details">
                         <field name="postcode"/>
-                        <field name="create_date"/>
                         <field name="expected_price"/>
                         <field name="selling_price"/>
                         <field name="bedrooms"/>
@@ -54,20 +52,19 @@
                     </group>
                 </group>
                 <notebook>
-                    <page string="Description">
+                    <!-- <page string="Description">
                         <field name="description" placeholder="Add property description..."/> 
-                    </page>
+                    </page> -->
                     <page string="Details">
                         <form>
-                            <group string="Details">
+                            <group>
                                 <field name="buyer_id"/>
                                 <field name="salesperson_id"/>
                                 <field name="property_type_id"/>
                                 <field name="tag_ids" widget="many2many_tags"/>
                                 <separator string="Summary"/>   
                                 <field name="total_area" readonly="1"/>
                                 <field name="best_price" readonly="1"/>
-                                <field name="state"/>
                                 <field name="validity_days"/>
                                 <field name= "date_deadline"/>
                             </group>
@@ -90,15 +87,13 @@
     </field>
 </record>
 
-
     <record id="estate_property_form_action" model="ir.actions.act_window">
         <field name="name">Property(Form)</field>
         <field name="res_model">estate.property</field>
         <field name="view_mode">form</field>
         <field name="view_id" ref="estate_property_form_view"/>
     </record>
 
-
     <record id="estate_property_search_view" model="ir.ui.view">
         <field name="name">estate.property.search</field>
         <field name="model">estate.property</field>
@@ -118,6 +113,4 @@
             </search>
         </field>
     </record>
-
-        
-</odoo>
+</odoo>

Estate/views/res_users_view.xml

@@ -22,4 +22,4 @@
           <field name="view_mode">form</field>
           <field name="view_id" ref="view_users_form_inherit_properties"/>
     </record>
-</odoo>
+</odoo>