[IMP] estate: add constraints

Author: djhan-odoo

estate/models/estate_property.py

@@ -1,4 +1,6 @@
-from odoo import models, fields, api, exceptions
+from odoo import models, fields, api
+from odoo.exceptions import ValidationError, UserError
+from odoo.tools.float_utils import float_compare, float_is_zero
 
 
 class EstateProperty(models.Model):
@@ -35,15 +37,24 @@ class EstateProperty(models.Model):
     total_area = fields.Float('Total Area', compute='_compute_total_area')
     best_price = fields.Float('Best Offer', compute='_compute_best_price')
 
+    _check_positive_selling_price = models.Constraint(
+        'CHECK(selling_price >= 0)',
+        'The selling price must be positive.',
+    )
+    _check_positive_expected_price = models.Constraint(
+        'CHECK(expected_price > 0)',
+        'The expected price must be positive.',
+    )
+
     @api.depends('garden_area', 'living_area')
     def _compute_total_area(self):
         for record in self:
             record.total_area = record.garden_area + record.living_area
-    
+
     @api.depends('offer_ids.price')
     def _compute_best_price(self):
         for record in self:
-            record.best_price = max(record.offer_ids, key=lambda p: p.price).price
+            record.best_price = max(record.offer_ids, key=lambda p: p.price, default=0).price
 
     @api.onchange('garden')
     def _onchange_garden(self):
@@ -53,19 +64,33 @@ def _onchange_garden(self):
         else:
             self.garden_area = 10
             self.garden_orientation = 'north'
-    
+
     def action_cancel_property(self):
         for record in self:
             if record.state == 'sold':
-                raise exceptions.UserError('Sold properties cannot be cancelled')
+                raise UserError('Sold properties cannot be cancelled')
             else:
                 record.state = 'cancelled'
         return True
 
     def action_sold_property(self):
         for record in self:
             if record.state == 'cancelled':
-                raise exceptions.UserError('Cancelled properties cannot be sold')
+                raise UserError('Cancelled properties cannot be sold')
             else:
                 record.state = 'sold'
-        return True
+        return True
+
+    @api.constrains('selling_price', 'expected_price')
+    def _check_selling_price(self):
+        for record in self:
+            if float_is_zero(record.selling_price, precision_rounding=0.0001):
+                continue
+            if float_compare(
+                record.selling_price,
+                record.expected_price * 0.9,
+                precision_rounding=0.01,
+            ) == -1:
+                raise ValidationError(
+                    "The selling price cannot be lower than 90 precent of the expected price."
+                )

estate/models/estate_property_offer.py

@@ -16,11 +16,16 @@ class EstatePropertyOffer(models.Model):
     validity = fields.Integer('Validity', default=7)
     date_deadline = fields.Datetime('Deadline', compute='_compute_date_deadline', inverse='_inverse_date_deadline')
 
+    _check_positive_price = models.Constraint(
+        'CHECK(price >= 0)',
+        'The price must be positive.',
+    )
+
     @api.depends('validity', 'create_date')
     def _compute_date_deadline(self):
         for record in self:
             record.date_deadline = fields.Date.add(record.create_date, days=record.validity)
-    
+
     def _inverse_date_deadline(self):
         for record in self:
             record.validity = (record.date_deadline - record.create_date).days

estate/models/estate_property_tag.py

@@ -6,3 +6,8 @@ class EstatePropertyTag(models.Model):
     _description = "Estate properties Tags"
 
     name = fields.Char('Name', required=True, translate=True)
+
+    _tags_uniq = models.Constraint(
+        'unique(name)',
+        f"The tag name already exists",
+    )

estate/models/estate_property_type.py

@@ -6,3 +6,8 @@ class EstatePropertyType(models.Model):
     _description = "Estate properties Types"
 
     name = fields.Char('Name', required=True, translate=True)
+
+    _types_uniq = models.Constraint(
+        'unique(name)',
+        f"The type name already exists",
+    )